M8: the browser becomes the storyteller

The interface was AI-DnD's with this product's features bolted into it. The
navigation read Home · Adventures · Scenarios · Settings · AI Chat; starting a
story meant first picking a *world*, and making a world meant a JSON stat-schema
form, a story-card table and an art picker. The play screen had a Branches tab.
The input had three modes. Sixteen of the sixteen controls on a two-turn story
had no accessible name — they were single glyphs with a tooltip.

All of that was measured in a real browser before anything was changed, and the
measurements are in planning/reports/M8-IMPLEMENTATION-REPORT.md §C. Almost
nothing underneath was wrong: the play loop, the history controls, the takes,
the Save Points, the state correction and the knowledge library all worked. What
was wrong was what a reader was asked to understand in order to use them.

So the shape now is one entry point and one screen:

  Campaigns -> Campaign -> Story
                           State · Knowledge · Context · Save Points · Settings

Everything that is not the story lives in a panel that starts closed. The
top navigation bar is hidden on the story screen entirely, because on that one
screen the story is the interface.

Play is one natural-language field. An action and a piece of quoted dialogue are
both just what the reader wrote, and B01/B02 confirmed against a real narrator
that the model reads the quotes without being told which kind of turn it is.
What survives from the old Story mode is a Story direction toggle, which is not
a fourth mode: it changes who is being spoken to, not what kind of action is
taken, and the box is visibly marked while it is on.

Branch, fork, node, merge and head appear nowhere a reader can see them. The
branch panel and the tree overlay are gone from the browser. The mechanism is
untouched — takes, divergence, retained futures and Save Points all still work,
and their endpoints are still tested. This is a decision about what a reader is
asked to understand, not a reduction of what the product can do.

The two defects worth the space:

A player action is stored with AI Dungeon's "> You " prefix. That was right when
the Do mode asked for a bare verb phrase. With one field the spec tells the
reader to write "I enter the tavern", and the result was "> You I enter the
tavern." — in the transcript, in the replayed history, and therefore in the
narration, where a small model imitates it and writes "You I thank her". M8's
own design surfaced it, so M8 fixed it: the prefix is added only when the reader
has not already written a subject. The ">" marker, which is what actually
identifies a player turn in the prompt, is unchanged in every case.

And a stale `.input-bar { display: flex }` in play.css overrode the new
composer, because that sheet is imported after the new one. The direction row
and the input row laid out side by side and the box was unusably narrow. Found
by opening the product in a browser, not by reading the CSS — which is the
argument for having done that first.

Failures now have the taxonomy the spec asked for rather than one toast: model,
generation, state, knowledge, server, each with the thing to do about it. A
failed turn leaves the reader's words in the box and says so. The classification
reads backend strings, so it is a fallback ladder rather than a lookup — an
unrecognised message still classifies, still shows the server's own words and
still offers Retry.

`Settings.model` could be empty with nothing saying so until the first turn
failed with a provider error. The header now reports Ollama in five states, and
an unconfigured or missing model offers the models actually installed on the
endpoint, from the connection test that already knew them. Nothing is chosen
automatically: an endpoint's first model may be an embedding model, which cannot
narrate at all.

Narrator prose is rendered as safe Markdown — headings, emphasis, lists,
blockquotes, code. The safety is structural rather than filtered: every node is
a React element built from parsed text, and there is no dangerouslySetInnerHTML
in the file. A sanitizer is not needed to make markup safe if markup is never
produced from input. Link schemes are checked with the URL parser rather than a
pattern, because the bypasses are all in the parsing. A remote image is a
placeholder naming the blocked address; the knowledge and context panels
deliberately do not use this renderer at all, because they exist to show a
reader exactly what is in their file.

Backend, and only what the browser could not otherwise reach:

  AdventureCreate.opening   a start action could only come from a Scenario, so
                            every campaign made in the new setup flow opened on
                            a blank page. Same node, same code path.
  canon_rules               campaign_canon has been the highest authority in a
                            campaign since M5, read by the prompt builder and
                            the state validator, and had no API at all — a
                            fixture had to write it with SQL.
  a 401 and a 429 message   the last user-facing text describing a hosted
                            deployment. One told the reader to check an API key
                            that has not existed since M2.

No schema change and no migration: proved by building a database with a server
running the M7 commit's own code and opening it with this one.

The project had no frontend tests. It has 132 now, across ten files, running
in about six seconds — the enabled state of every history control, the take
selector, the confirmations, the panels, the five model states, the failure
taxonomy, the focus trap, accessibility, and that the reserved dictation control
never touches the microphone. Writing them found a real defect: the focus trap
filtered candidates with offsetParent, which is null inside the fixed-position
ancestor the dialog has and which jsdom never computes — it would have behaved
differently in the tests from the browser.

They do not replace the real-browser runs, and both kinds of evidence are in the
report. The browser suites drive the production build served by the real backend
with a real local narrator, including a genuine process restart.

A verification pass over all of it then found three more, each by driving the
product rather than reading it:

Stepping between alternate takes did nothing. The pager asked whether a take
lived on another line by comparing `target.branch_id !== action.branch_id`, and
`ActionOut` has never carried `branch_id` — so the comparison was permanently
`number !== undefined`, always true, and every step took the branch-switch path.
For two takes of an ordinary retry, which share a line until one is written
below, that meant switching to the line already being read: the same window came
back and nothing moved. D07 is a required v1 acceptance test. The fix needed no
new field — the variants list already carries every attempt's branch and marks
the live one.

The first regression test for that passed against the broken code, because its
fixture gave the action a `branch_id` the real payload never sends. That is the
exact failure M7's review was about, so the fixture was corrected, the tests were
re-run against the reverted code and failed for the right reason, and the
fixture now carries a docstring saying why the field must never come back.

And the knowledge panel pointed readers at an "embedding model" while the
setting is called "Model for meaning-based search" — a reader sent looking for a
field that does not exist by that name.

Campaign canon was measured rather than assumed. Editing it after play is a
configuration change: every turn already played keeps the canon it was actually
given, in its own context snapshot, and the accepted story, the state document
and the state audit log are byte-identical across an edit. It is not routed
through M5's state audit, because canon is not narrative state and doing so
would create the second representation the spec forbids. What the editor does
now is say so, once a campaign has moments.

`BROWSER-UX-SPEC.md` §38 asked for a "Show Hidden Story State" toggle. There is
no hidden story state — a secret lives in a narrator-only knowledge source and
never enters the state document. The section is rewritten to require what it
actually meant: ordinary surfaces must not carry narrator-only information,
advanced inspection must withhold it by default behind an explicit warned
choice, and no second store may be invented to give a toggle something to
reveal. The protection is stricter than before, not weaker.

Closeout. An independent review returned M8 IMPLEMENTATION: PASS subject to
evidence and documentation cleanup, and this commit carries that cleanup:

The report named two frontend bundles as the artifact behind its acceptance
evidence. The saved run logs settle it. index-Ii-lARp9.js, built at 18:53:02
from this tree, is the one final frozen artifact behind all 157 browser checks;
index-C6E5Uvtu.js is superseded — it predates the D09 fix and its acceptance
suite ended 54/55 on exactly that defect. No tracked file under backend/app or
frontend/src has a modification time after the freeze, so the whole final
campaign describes one build. §P sets the two side by side.

Finding 14 — the app budgets 16,384 prompt tokens while an Ollama that sees no
VRAM enforces 4,096 — is resolved operationally, with no application change.
The OpenAI-compatible endpoint this app speaks accepts num_ctx and ignores it,
and reloads the model at its own default, so a native call cannot prime it
either. A model derived with POST /api/create carries the parameter, is honoured
through the app's own OpenAI-compatible path, and appears in /v1/models — which
is the listing the Settings model picker already reads. Measured end to end.
The procedure is in DEVELOPMENT.md; nothing in the repository depends on any
particular derived model existing. Adding provider code to work around this was
declined deliberately: it would mean either a second native request path,
against ADR 011, or a parameter the endpoint provably ignores.

The §38 rewrite is ratified as a requirement clarification aligned with the
implemented architecture, and the spec gains the clause finding 3 was really
about: withheld material must be absent from the rendered DOM, not merely
collapsed in it.

The report's §U carries the M9 handoff — what a portable campaign has to include,
whether historical context snapshots belong in the bundle, what happens to
inherited story cards, and that a restored campaign may meet a different context
window than the one that wrote it. None of it is implemented here.

Final: backend 950 passed / 14 skipped; frontend 132 passed; lint, production
build and Docker build clean; 157 browser checks across six suites, zero
failures. M8 is implemented, verified, reviewed and accepted (2026-09-06).
M9 has not been started.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017HdaXiFbscatQaLS7dJk6b
This commit is contained in:
JesseMarkowitz
2026-09-06 23:31:45 -04:00
co-authored by Claude Opus 5
parent 480414efe0
commit 1ce9972760
89 changed files with 11985 additions and 6532 deletions
+16
View File
@@ -155,6 +155,22 @@ class Adventure(Base):
# and a science-fiction one forbidding faster-than-light travel use the same
# field and the same validator; neither word appears in the application.
campaign_canon: Mapped[dict | None] = mapped_column(JSON, nullable=True)
@property
def canon_rules(self) -> list[str]:
"""The `rules` list alone, which is the half a person writes.
`campaign_canon` also carries `forbidden_status_changes`, a structured
shape the browser has no editor for and does not need one for — a rule
like "nothing dead becomes alive" is expressible as a sentence. So the
API exposes the sentences and leaves the structured half to whatever
wrote it, rather than round-tripping a shape the UI would flatten.
"""
canon = self.campaign_canon
if not isinstance(canon, dict):
return []
rules = canon.get("rules")
return [r for r in rules if isinstance(r, str)] if isinstance(rules, list) else []
# The ${Placeholder} answers collected when this adventure was started, kept
# so "Update from scenario" can re-fill freshly copied scenario text with the
# same values. NULL for adventures created before this column existed.
+18 -10
View File
@@ -381,21 +381,29 @@ class OpenAICompatibleProvider(Provider):
return vectors
def _friendly_http_error(self, status: int, detail: str) -> str:
"""The message a reader sees when the endpoint answers with an error.
M8 rewrote two of these. They were the last user-facing text describing
a hosted deployment this build does not have: a 401 advised checking an
API key, and a 429 explained a shared free tier's daily cap. There is no
API key field — M2 removed it with the cloud providers — and no shared
tier, so both sent a reader looking for a setting that does not exist.
Ollama's own 401 and 429 mean something else entirely.
"""
if status == 401:
return "Authentication failed — check your API key in Settings."
return (
"The endpoint refused the request as unauthorized (HTTP 401). "
"An ordinary local Ollama does not require authentication — "
f"check that {self.base_url} is the endpoint you meant. {detail}"
)
if status == 404:
return (
f"Endpoint or model not found (HTTP 404). Check the endpoint URL and that "
f"model '{self.model}' exists. {detail}"
)
if status == 429:
# OpenRouter's shared free tier has a per-day cap. Distinguish it
# from a short-term burst limit, so the message tells the reader what
# to do.
if "free-models-per-day" in detail:
return (
"The free demo has hit its daily request limit (resets at "
"00:00 UTC). Please try again later."
)
return "The AI is getting too many requests right now — wait a moment and try again."
return (
"The endpoint is refusing further requests for now (HTTP 429). "
"Wait a moment and try again."
)
return f"AI endpoint returned HTTP {status}: {detail}"
+42 -11
View File
@@ -195,20 +195,37 @@ def create_adventure(
# everywhere, which buys nothing.
tree.head_branch(db, adventure)
# M8: canon written at setup. Stored in the same document the prompt and the
# validator already read, so nothing downstream learns a second shape.
rules = [r.strip() for r in payload.canon_rules if r.strip()]
if rules:
adventure.campaign_canon = {"rules": rules}
if scenario:
for ref, spec in scenario_card_specs(scenario, values).items():
db.add(models.StoryCard(adventure_id=adventure.id, source_ref=ref, **spec))
if scenario.prompt.strip():
opening = models.Action(
adventure_id=adventure.id,
type="start",
text=fill_placeholders(scenario.prompt, values),
)
# Record the starting state on the opening node, so undoing or
# retrying the first turn has a state to roll back to.
attempts.snapshot_outcome(adventure, opening)
tree.place_action(db, adventure, opening)
db.add(opening)
# The opening scene. A scenario's prompt and M8's `opening` field are the
# same thing arriving by different routes, so they build the same node —
# the scenario wins when both are present, because it is the more specific
# request. Everything downstream (Undo to the opening, retrying the first
# turn, the drop cap) keys on the `start` type and is unchanged.
opening_text = (
fill_placeholders(scenario.prompt, values)
if scenario and scenario.prompt.strip()
else payload.opening.strip()
)
if opening_text:
opening = models.Action(
adventure_id=adventure.id,
type="start",
text=opening_text,
)
# Record the starting state on the opening node, so undoing or
# retrying the first turn has a state to roll back to.
attempts.snapshot_outcome(adventure, opening)
tree.place_action(db, adventure, opening)
db.add(opening)
db.commit()
db.refresh(adventure)
@@ -296,6 +313,20 @@ def update_adventure(
adventure: models.Adventure = Depends(current_adventure),
):
fields = payload.model_dump(exclude_unset=True)
# M8. `canon_rules` is a read-only view onto the stored `campaign_canon`
# document, so it is written by hand rather than by the setattr loop — and
# only the `rules` key is replaced. Whatever else the document holds
# (`forbidden_status_changes`, which has no browser editor) is left exactly
# as it was, so editing canon through the browser cannot silently discard
# the structured half a fixture or an import wrote.
if "canon_rules" in fields:
rules = [r.strip() for r in (fields.pop("canon_rules") or []) if r.strip()]
canon = dict(adventure.campaign_canon or {})
if rules:
canon["rules"] = rules
else:
canon.pop("rules", None)
adventure.campaign_canon = canon or None
for field, value in fields.items():
setattr(adventure, field, value)
# M6: a summary the reader typed is still a summary, so it is anchored to
+31 -1
View File
@@ -82,8 +82,35 @@ async def with_turn_lock(adventure_id: int, gen):
_active_turns.discard(adventure_id)
#: Openings that mean the reader has already written the subject of the sentence.
#:
#: Matched as whole words, longest first, so "I'm" is recognised before "I".
_FIRST_PERSON = ("i ", "i'm ", "i've ", "i'll ", "i'd ", "my ", "we ", "we're ")
def format_player_input(action_type: str, text: str) -> str:
"""Formats player input the way AI Dungeon does."""
"""Formats player input the way AI Dungeon does — with one M8 correction.
The convention is a `>` marker and second person: typing `look around` in
the old Do mode stored `> You look around.`, which reads correctly and shows
the model whose turn it is.
**M8 broke that assumption and this repairs it.** `BROWSER-UX-SPEC.md` §12
replaced the Do/Say/Story selector with one natural-language field, and §11
tells the reader to write sentences like *"I enter the tavern."* Prefixing
that produced `> You I enter the tavern.` — in the transcript, in the
replayed history, and therefore in the narration, where a small model
imitates it and writes "You I thank her". It was visible in the very first
browser pass of the new composer.
So the prefix is added only when the reader has *not* already written a
subject. First person is left alone; everything else keeps the old
behaviour, and the `>` marker is unchanged in every case, because that is
what actually distinguishes a player turn in the prompt.
Storage is unchanged for text that was already formatted — see
`test_take_parentage.py`, which guards against `> You > You ...`.
"""
text = text.strip()
if action_type == "say":
text = text.strip('"')
@@ -95,6 +122,9 @@ def format_player_input(action_type: str, text: str) -> str:
text = text[4:]
if text and text[-1] not in ".!?…":
text += "."
lowered = text.lower()
if any(lowered.startswith(opening) for opening in _FIRST_PERSON):
return f"> {text}"
return f"> You {text}"
return text # The "story" type is appended as raw text.
+25
View File
@@ -143,6 +143,24 @@ class ScenarioListItem(ORMModel):
class AdventureCreate(BaseModel):
scenario_id: int | None = None
title: Name | None = None
# M8: the opening scene, for a campaign started without a scenario.
#
# A scenario's `prompt` already becomes the campaign's `start` action, and
# this is the same thing said directly. It exists because M8's setup flow
# creates a campaign from a form rather than from a template
# (`BROWSER-UX-SPEC.md` §41), and without it every new campaign opens on a
# blank page — the reader has to invent the situation *and* the first move
# in one box. Ignored when `scenario_id` is given, which already supplies one.
opening: Prose = ""
# M8: the campaign's own rules, as a list of sentences.
#
# The column has existed since migration 82 and both the prompt
# (`context/builder._canon_section`) and the state validator
# (`narrative/apply`) already read it — it simply had no way in from the
# browser, so a fixture had to write it with SQL. This is the highest
# authority in the campaign, which is exactly why a person setting one up
# needs to be able to state it.
canon_rules: list[Name] = []
# The `${Placeholder}` values collected from the player at the start, which
# is the AI Dungeon behavior.
placeholders: dict[str, str] = {}
@@ -165,6 +183,10 @@ class AdventureUpdate(BaseModel):
persona_name: PersonaName | None = None
persona_pronouns: PersonaPronouns | None = None
persona_desc: Prose | None = None
# M8. See `AdventureCreate.canon_rules`. Editable after setup because canon
# is the thing a reader most often gets wrong first and needs to correct —
# "resurrection is impossible" is easier to write once the story has tried it.
canon_rules: list[Name] | None = None
class AdventureRefresh(BaseModel):
@@ -456,6 +478,9 @@ class AdventureOut(ORMModel):
persona_name: str
persona_pronouns: str
persona_desc: str
# M8. Read from the `canon_rules` property on the model, which pulls the
# sentence list out of the stored `campaign_canon` document.
canon_rules: list[str] = []
created_at: datetime
updated_at: datetime
story_cards: list[StoryCardOut] = []