Give the tests one setup instead of thirty-five

Every test module carried the same eight-line prologue redirecting the
database to a temp file. Only the first one to be imported ever took
effect: `app.database` reads `AIDND_DB_PATH` at import and builds `engine`
from it once, so by the time the second module ran the engine already
existed. The other 34 copies created a temp file that nothing opened and
nothing deleted, and leaked one per module per run.

`conftest.py` now does it once, which is early enough because pytest
imports conftest before any test module. It also deletes the file when the
run ends. The tests still share one database, exactly as they already did:
each `client` fixture calls `create_all` on setup and `drop_all` on
teardown, so no test sees another test's rows.

`tests/fakes.py` holds the one `ScriptedProvider`. Nine modules each had a
copy, and the copies had drifted into four feature sets, so a test that
needed to raise a provider error had to be written in one of the files
whose copy supported that. The shared one is the superset. The two
`FakeProvider` copies were the same class with a fixed reply, so they use
it too. `test_chat.py` keeps its own, which implements `chat` rather than
`generate` and records what it was constructed with.

An autouse fixture resets the fake's class state between tests, so a stale
reply list can no longer reach the next test.

435 lines out of the suite. 549 tests pass. Verified live by sabotage:
breaking the shared fake fails 13 tests across four modules.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014Dix4oGV3njgWRdu7P9t6r

This commit is contained in:

parththakkar106

2026-08-29 00:47:46 +05:30

co-authored by

Claude Opus 5

parent b1772c6e21

commit 32cd7c1077

37 changed files with 123 additions and 460 deletions

									
										backend/tests/test_egress.py
									
		-9
	
												View File
												
				@@ -17,15 +17,6 @@ Two kinds of guard live here, and both are needed:

				    python -m pytest tests/test_egress.py -v

				"""

				import os

				import tempfile

				_tmp = tempfile.NamedTemporaryFile(suffix=".db", delete=False)

				_tmp.close()

				os.environ["AIDND_DB_PATH"] = _tmp.name

				os.environ.pop("AIDND_DATABASE_URL", None)

				os.environ.pop("DATABASE_URL", None)

				import json

				import random