M9: a campaign you can actually get back

A campaign could already be exported and imported. What could not survive the
trip was everything that explains it: the state events behind the authoritative
document, the prompt each turn was actually given, the passages it was shown,
the summaries that carry long-story continuity, and which take belonged to which
turn. An imported campaign could be read and could no longer say why it was what
it was — and a manual correction, the one state change no narration explains,
was indistinguishable from something the story had established.

The bundle is now `ai-dnd-adventure-v3`, and the version is the design rather
than a side effect. Everything added here could have been another optional key,
the way persona, Save Points, narrative state and imported knowledge each were.
That mechanism stops working at exactly this addition: a v2 file with no prompt
provenance is ambiguous between "written before M9" and "written by M9 from a
campaign that has none", and those are different facts about a campaign. A
version number is how a recovery file states what it was capable of recording.
v1 and v2 still import, and every seam from pre-active-head onward is tested for
the rule that an older file is never reinterpreted under a newer assumption.

Two categories became three. "Chosen travels, derived is recomputed" was enough
until stored prompts had to be decided: they are derived, and they must travel
anyway. The test that separates evidence from cache is not "could this be
recomputed" but "would a recomputation answer the same question" — a rebuilt
search index answers the same question, a rebuilt prompt says what the turn
would be told *now*, which is the opposite of what the inspector is for.

Also here: a real SQLite backup, through the online backup API rather than a
file copy, taken while the application is running and verified before it is
kept; story cards settled as compatibility-only legacy data and taken out of the
narrator's prompt, because they were the untracked path around knowledge
authority that IMPORTED-KNOWLEDGE-DESIGN §73 already forbade; and no schema
change at all, proved against a database M8's own code wrote.

Three defects, found by running the milestone's own tests rather than by reading
them. Deleting a campaign leaked its FTS index rows, and SQLite then handed the
freed ids to the next source imported into any campaign, which failed with an
integrity error that Reindex could not repair — both ends are closed, and a
database already carrying the damage now repairs itself. An imported node with
no state snapshot was being stamped with the campaign's head state, so an Undo
to turn 2 showed what the story knew at turn 20. And the snapshot relink did not
persist at all, because it mutated a dict in place on a column SQLAlchemy tracks
by assignment: it looked correct in memory and wrote the wrong ids to disk.

Carrying per-turn prompts looked like it would halve the length of campaign that
can be restored. Measured — and after compressing them inside the file —
everything M9 added costs 12% of it: the import ceiling moves from about 318
turns to about 279, against a 100-turn certification target. The dominant cost
is not M9's at all. The per-position narrative state document is 74% of a
bundle, and v2 already carried it.

Backend 1,102 passed / 14 skipped / 0 failed. Frontend 145 passed. Lint,
production build and Docker build clean. Verified across two server processes
with two data directories, and in a real browser against a real narrator.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qyn3oRd4D6pi72nKBG725B

backend/app/routers/adventures/bundle_io.py

@@ -1,7 +1,31 @@
 """Exporting an adventure to a bundle, and importing one back.
 
 `app/bundle.py` owns the format and the version handling. These two endpoints
-only check ownership and hand the work over.
+only check ownership, apply the caps, and hand the work over.
+
+## Why the import is one transaction and two phases
+
+`bundle.plan` reads the whole file and returns a checked, normalised tree
+without opening a session, touching a row or creating an adventure. Everything a
+hand-edited file can get wrong about its own shape — a node on a branch that is
+not listed, a fork from a branch listed after it, a head past the story, an
+audit record naming a turn that is not there — is a 400 from a function with no
+side effects.
+
+Only then does `bundle.materialize` write, and it writes inside the single
+transaction this endpoint commits at the end. So there are exactly two outcomes
+a caller can see, and M9 requires them to be distinguishable:
+
+    the authoritative import failed        4xx, and no campaign exists
+    the authoritative import succeeded     201, and the campaign is complete
+
+A third state — the campaign landed and a *rebuildable* index did not — is not a
+failure of the import and does not roll it back. Passages, the lexical index and
+vectors are all a deterministic function of content the file carries, so losing
+them costs a rebuild rather than data. It is reported on the response as a
+warning, it is visible per source in the Knowledge panel, and Reindex is the
+repair. Refusing a whole campaign because a search index would not build would
+trade the valuable thing for the cheap one.
 """
 
 from fastapi import Body, Depends, Request
@@ -18,15 +42,15 @@ def export_adventure(
     db: Session = Depends(get_db),
     adv: models.Adventure = Depends(current_adventure),
 ):
-    """Returns a full backup: plot components, story cards, scripts, state, and tree.
+    """Returns a full backup: the story, the tree, the state, and the evidence.
 
-    `app/bundle.py` owns the format, in both of its versions. A backup outlives
-    the schema, so no call site decides anything about its shape.
+    `app/bundle.py` owns the format, in all three of its versions. A backup
+    outlives the schema, so no call site decides anything about its shape.
     """
     return bundle.export(db, adv)
 
 
-@router.post("/import", response_model=schemas.AdventureOut, status_code=201)
+@router.post("/import", response_model=schemas.ImportedAdventureOut, status_code=201)
 def import_adventure(
     request: Request,
     payload: dict = Body(...),
@@ -58,18 +82,29 @@ def import_adventure(
         branches=story["branches"],
     )
 
-    adventure = bundle.materialize(db, payload, story, user.id)
-
-    db.commit()
+    try:
+        adventure, report = bundle.materialize(db, payload, story, user.id)
+        db.commit()
+    except Exception:
+        # Explicit, rather than left to the session closing. The planner has
+        # already refused everything it can see, so anything raising here is a
+        # write that surprised us — the case where leaving a partial campaign
+        # behind would be worst, and the case a test can only assert on if the
+        # rollback is a statement rather than a side effect of teardown.
+        db.rollback()
+        raise
     db.refresh(adventure)
     # A campaign exported while undone imports undone (M3), so the history
     # controls have to be right on the response that opens it — otherwise the
     # first thing the reader sees about a story with a retained future is a
     # greyed-out Redo.
-    out = schemas.AdventureOut.model_validate(adventure)
+    out = schemas.ImportedAdventureOut.model_validate(adventure)
     out.can_undo = head.can_undo(db, adventure)
     out.can_redo = head.can_redo(db, adventure)
-    # This is not a funnel step. A returning player imports a bundle, so it
-    # says nothing about how far a first-time visitor got. It is counted anyway,
-    # because it is the clearest evidence that anyone uses the export format.
+    out.import_warnings = [
+        f"The search index for “{failure['title']}” could not be rebuilt "
+        f"({failure['detail']}). The file itself imported intact — use Reindex "
+        f"in the Knowledge panel to try again."
+        for failure in report["knowledge_index_failures"]
+    ]
     return out