Answer the review, and keep the opening node's bank
Nine findings from a review of the phase-14 stack. The one about a retry withdrawing a memory is not a bug — a memory anchored to a node describes that node, and it goes when the node goes. The root is the exception, and it is the only one: migration 62 parked every memory written before memories had coordinates on depth 0, so withdrawing the opening node would retire a whole bank nobody attached there. A memory with no source range covers no story and now stays; a summary that genuinely ends there is still withdrawn. The rest are repairs. * The adventure list quoted whichever attempt was written last rather than the one the story tells, so switching back left the index disagreeing with the page. * A v1 import gave a typed memory no depth, rebuilding the NULL the migration exists to remove — invisible until the imported adventure forked. * The action cap counted a v1 file's turns, and a turn expands into a row per saved attempt, so a file inside the cap could write a multiple of it. * Forking a live node on a borrowed ancestor promoted a sibling on a branch the caller never named. It is a branch switch, and now says so. * Switching attempts left the state, status and memory panels reading the previous take: the story does not change length, so nothing keyed on its length noticed. Same class as the branch-switch bug this phase already fixed. * A retry after switching back numbered the new attempt into the middle of the group instead of the end. * The cursor backfill numbered every action in the table once per adventure; correlated to the adventure being updated, it is an index lookup instead. * Renaming a branch answered own_actions=0. And one behaviour change recorded rather than repaired: script-visible history and actionCount no longer count blank-text rows. That is the right shape and there is no reading compatible with both, so plan/14 says so. 409 tests. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015H5qiyiR7gtFQaoDphHZ3g
This commit is contained in:
committed by
Parth
co-authored by
Claude Opus 5
parent
2d38a162d4
commit
4af6e17406
@@ -545,6 +545,16 @@ def _write_memories(
|
||||
# last action it summarises, which on one branch is that node's depth.
|
||||
if memory.depth is None and memory.source_end is not None:
|
||||
memory.depth = memory.source_end
|
||||
# A v1 memory that summarises nothing — one the player typed — has no
|
||||
# depth to derive, and leaving it NULL here would rebuild by import the
|
||||
# exact state migration 62 exists to end: `Path._entry_clause` compares
|
||||
# `depth <= max_depth`, which a NULL fails, so the memory would vanish
|
||||
# from every branch the moment the imported adventure was forked. The
|
||||
# root is the same answer the migration gives, and for the same reason
|
||||
# — 0 is at or before every fork point, so it is visible from every
|
||||
# path this adventure can grow.
|
||||
if memory.depth is None:
|
||||
memory.depth = lineage.ROOT_DEPTH
|
||||
db.add(memory)
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user