Files
JesseMarkowitzandClaude Opus 5 62a997f364 M4: close out Save Points, with browser verification
Closes M4. The review's three findings are fixed, the durability rule the
specification always implied is now enforced, and M3's and M4's browser
behaviour has been verified in a real browser for the first time.

B-1 -- the Save Point list was an N+1 that loaded whole Action rows,
narration included, to answer "does a row exist here". It is now one bulk
two-column coordinate query plus one lineage: 53 SELECTs for 25 Save Points
became 5, and the count no longer grows with the list. The clause is an OR
of exact (branch, depth) pairs rather than two IN lists, because the cross
product would report a Save Point resolved on the strength of another one's
depth existing on this one's branch. A test builds exactly that trap.

B-2 -- reclassified during closeout from "missing warning" to a behaviour
defect, and fixed as one. STORY-BRANCH-SEMANTICS §19 says a named checkpoint
remains until explicitly deleted, and §28 already required future cleanup to
retain checkpoint-referenced paths; a cascade that silently removed Save
Points with a branch violated both, and a warning would only have documented
the violation. A branch a Save Point names can no longer be deleted. The
request is refused with the offending Save Points named, the user deletes
them explicitly -- which deletes no story -- and the branch then goes. The
scope is the subtree, because deleting a branch takes its descendants. Both
delete controls disable and explain. Recorded as a new §19.1; models.py,
TECHNICAL-DESIGN §8.8 and DATA-MODEL §8 had all recorded the cascade as the
rule and now record the refusal.

An earlier pass in this same closeout had kept the cascade and added a
warning. That was the wrong fix and its tests were replaced rather than left
standing, since they pinned the defect.

B-3 -- the D11/L03 automation never left one process, so it could not
distinguish durable state from a live Python object. It now spawns real
server processes, kills the first, and reads the campaign back with the
second.

C-5 -- creating a Save Point takes the campaign's turn lock. "Save where I
am" has to name one committed position, and the head is what a turn in
flight is about to move. Rename and Delete deliberately do not take it.

The architecture is untouched: a Save Point is still name + note +
(branch, depth), and restore is still coordinate -> head.move_to_node ->
head.move_to -> attempts.restore_state. No second restore path, no state
copied into a checkpoint, no fork on restore.

Browser verification -- the first in this project, and it covers both
milestones. Firefox 154.0.1 through geckodriver over the W3C WebDriver
protocol, driving the rendered DOM: 47/47 checks, twice, on independent
databases, no console errors. M3's Undo/Redo enable states, transcript
movement, Retry and the take pager, divergence retiring Redo; M4's whole
Save Point lifecycle, both confirmations, and the new branch-delete refusal
including its recovery. No dependency was added: the WebDriver client is
stdlib HTTP.

No application defect was found by the browser. Four failures occurred, all
in the harness -- a wrong SPA route, a wait comparing transcript length when
the empty-story placeholder is longer than the first turn, a fixture
deleting the branch it was reading, and a reload assertion that sampled
once instead of waiting. The last was checked against the app before being
called a harness bug.

Tests: 698 backend pass (was 680), 60 M4, 94 M3 history, 66 export/
migrations, 93 security/local-only. Frontend lint and build clean, Docker
build clean, loopback binding unchanged. No assertion weakened, no skip
added.

Planning: STORY-BRANCH-SEMANTICS §19.1 is the only behavioural change and it
strengthens §19. V1-ACCEPTANCE-TESTS records D11-D14, I04, L03 and the
E-series, keeping automated, live-runtime and browser evidence distinct, and
weakens no pass condition. DATA-MODEL records the coordinate with the retry
measurement that settles it. BROWSER-UX-SPEC rules for Moment over Turn.
BUILD-MILESTONES marks M4 COMPLETE, closes M3's browser condition, and lists
what M5 inherits. VERSION adds v2.6.

No new ADR: ADR 005 already decides that history is preserved rather than
overwritten, and §19.1 is that decision applied to checkpoint-referenced
history.

M4 is closed. M5 may now be briefed; it has not been started.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PWU4gTfLYY6Qq9U7aa9Qw2
2026-09-04 06:34:56 -04:00

19 KiB

Adventure Storyteller — Planning Package

This file is the index. Start here.

Current state: Phase 0 complete; AI-DnD forked as the production base; milestones M1, M2, M3 and M4 implemented and accepted (M3 and M4: 2026-09-03). Next: M5 — Genre-Neutral Authoritative Narrative State. Its brief has not been written yet, and writing it is the current action.

Package version: see VERSION.md, which records what each revision changed and why.

Where documentation lives

planning/
    active specifications and implementation planning — authoritative

planning/DECISIONS/
    active architectural decisions (ADRs) — authoritative

planning/reports/
    the current milestone's implementation report — evidence, not instruction

planning/archive/
    historical evidence and completed planning material;
    not authoritative for current implementation

You do not need to open planning/archive/ to do ordinary milestone work. Go there only when an active document sends you for a specific piece of historical evidence. If an archived document contradicts an active one, the active one is right.

Outside planning/: README.md describes the application, DEVELOPMENT.md is setup and local operation, and PROVENANCE.md records what came from upstream AI-DnD and what each milestone changed.

Which document controls

When two documents appear to conflict, the one higher in this list wins:

  1. SPECIFICATION.md — product requirements and required behavior.
  2. The detailed behavior/design documents: STORY-BRANCH-SEMANTICS.md, CONTEXT-AND-MEMORY.md, IMPORTED-KNOWLEDGE-DESIGN.md, SECURITY-THREAT-MODEL.md, MEDIA-EXTENSION-CONTRACT.md, BROWSER-UX-SPEC.md, DATA-MODEL.md.
  3. V1-ACCEPTANCE-TESTS.md — the observable pass/fail contract.
  4. TECHNICAL-DESIGN.md — the selected implementation architecture.
  5. The ADRs in DECISIONS/.
  6. BUILD-MILESTONES.md — implementation sequence. It sequences work; it does not override product behavior.
  7. The current milestone report in reports/, then planning/archive/ — evidence and historical findings, authoritative over nothing.

Two standing qualifications:

  • Candidate repositories and research reports are not specifications. In particular, ai-adventure is an implementation reference for selected patterns; its behavior does not override this package.
  • Where an ADR records the architecture chosen to implement a requirement stated elsewhere, both stand: ADR 005 states the history requirement and ADR 012 states the architecture that implements it.

The active documents

Document What it is for
SPECIFICATION.md What the product must do. The top of the authority order.
TECHNICAL-DESIGN.md The selected architecture, including what M1-M3 built, recorded as fact.
DATA-MODEL.md Entities, the stored head, branch disposition, and the export shape.
STORY-BRANCH-SEMANTICS.md Undo/Redo/Retry/branch/take behavior, including the M3 ratifications.
CONTEXT-AND-MEMORY.md Prompt assembly, summarization, branch-safe memory.
IMPORTED-KNOWLEDGE-DESIGN.md Canon / Reference / Inspiration knowledge as a first-class subsystem.
SECURITY-THREAT-MODEL.md The trust boundary, and the inference endpoint policy as implemented.
MEDIA-EXTENSION-CONTRACT.md The contract future image/video/audio/TTS/STT work must fit.
BROWSER-UX-SPEC.md The browser surface, and what is deliberately not in it.
BUILD-MILESTONES.md M1-M11, what each delivers, what is done, and the notes each milestone leaves its successors.
V1-ACCEPTANCE-TESTS.md The pass/fail contract v1 is measured against.
TEST-CAMPAIGN-FIXTURE.md The standard campaign the acceptance tests are run on.
VERSION.md Package revision history: what each closeout changed.
PROJECT-SOURCES.md Which files to upload as ChatGPT Project Sources.

Reading order for a new coding agent

  1. This file.
  2. SPECIFICATION.md
  3. TECHNICAL-DESIGN.md
  4. BUILD-MILESTONES.md — find the milestone you are being asked to do.
  5. STORY-BRANCH-SEMANTICS.md
  6. DATA-MODEL.md
  7. CONTEXT-AND-MEMORY.md
  8. IMPORTED-KNOWLEDGE-DESIGN.md
  9. SECURITY-THREAT-MODEL.md
  10. BROWSER-UX-SPEC.md
  11. V1-ACCEPTANCE-TESTS.md
  12. DECISIONS/ — all of them; they are short.
  13. reports/M4-IMPLEMENTATION-REPORT.md, for what the last milestone actually left behind. Nothing in planning/archive/ unless sent there.

Architectural decisions

Active ADRs, all of which still constrain current or future work:

ADR Decision
001-browser-first.md The UI is a browser application.
002-ollama-only-v1.md Ollama-compatible local inference only; trusted-LAN HTTPS with a private CA is verified, never bypassed.
003-authoritative-local-state.md The application owns authoritative state; the model does not.
004-local-only-production.md Local-only runtime; no cloud, telemetry or runtime remote assets.
005-branch-preserving-history.md History is preserved, not overwritten. The requirement.
006-genre-agnostic-core.md The core state model is genre-agnostic.
007-future-media-extension.md Media generation stays optional and decoupled.
009-ai-dnd-production-base.md AI-DnD at d72f7c1b… is the production base.
010-explicit-typed-narrative-state-events.md Explicit typed events / absolute assignments, not relative deltas.
011-local-inference-endpoint-policy.md Address allowlist, deny by default, checked twice, TLS mandatory.
012-active-head-non-destructive-history.md The stored active head. The architecture implementing ADR 005.

008-phase0-before-build-plan.md was a process gate — do not begin production work until Phase 0 closes — which Phase 0 satisfied on 2026-09-01. It is in archive/decisions/ and constrains nothing now. ADR numbering continues from 012; 008 is not reused.

Milestone reports

reports/ holds the report for the milestone most recently completed, because that is the one the next milestone's planning has to consult:

  • reports/M4-IMPLEMENTATION-REPORT.md — M4's review and its evidence record.

Completed earlier milestones are in archive/milestone-reports/, which M3's report joined when M4's landed: a milestone report is useful during the immediate next milestone and historical afterwards. M3's is now at archive/milestone-reports/M3-IMPLEMENTATION-REPORT.md, unedited.

The decision this package rests on

Phase 0A static research and Phase 0B local validation closed on 2026-09-01 with one decision:

Fork AI-DnD at upstream commit d72f7c1bda0f34fccd84afb7a25c34eb01c901de.

It was chosen on measured behavior, not feature count: AI-DnD already had the browser UI, the FastAPI service boundary, SQLite persistence, parent-linked story history, alternate takes, branch-aware state snapshots, local Ollama operation, branch-scoped memory, prompt inspection, streaming, export/import and a substantial test suite. The composition of ideas selected around it:

AI-DnD production base
  + ai-adventure state/event/commit/checkpoint/privacy patterns
  + Open Dungeon story-reading and future-media UX patterns
  + Chronicler memory-authority concepts
  + Interactive Fiction Framework canon/validation concepts
  + Gamentic provider-neutral media concepts

This is not a repository merge. AI-DnD is the ownership center; the others are implementation references only.

Phase 0B also corrected several Phase 0A assumptions, and those corrections are now built into the active documents rather than needing to be read from the research: shipped Undo was destructive with no Redo (ADR 012 replaced it); relative-delta world state can be semantically wrong while syntactically valid (ADR 010); tiktoken and Google Fonts broke offline operation (fixed in M1); export had to carry the head position (M3); Story Cards were not a sufficient imported-knowledge store (IMPORTED-KNOWLEDGE-DESIGN.md).

The evidence is in archive/phase0/, and archive/phase0/PHASE-0B-RECOMMENDATION.md is the strongest single document there. It is research evidence, not a specification, and it was not rewritten to match later conclusions.

Foundational Decisions

The following are settled for v1:

  • browser-first UI,
  • local-only runtime across user-controlled local infrastructure,
  • Ollama inference with same-host loopback as default and explicitly configured trusted-LAN inference supported,
  • single-user deployment,
  • AI-DnD production base at the pinned Phase 0B commit,
  • application-owned authoritative state,
  • complete retained transcript/history,
  • simple user-facing Undo/Redo/Retry/Save Point semantics,
  • non-destructive head-cursor history internally,
  • new write after moving backward creates a new continuation while retaining the old future,
  • abandoned history is retained and marked disposable; no automatic cleanup is required in v1,
  • named checkpoints remain until explicitly deleted,
  • genre-agnostic core state,
  • explicit typed narrative-state events/absolute assignments rather than ambiguous relative deltas,
  • hybrid state model: validated events plus state snapshots/cache,
  • branch/lineage-safe summaries and memories,
  • imported knowledge is a separate first-class subsystem rather than an extension of AI-DnD Story Cards,
  • knowledge classes: Canon / Reference / Inspiration,
  • local lexical retrieval plus local semantic retrieval where practical,
  • prompt/context provenance and inspection,
  • export/import must preserve active branch and active head position, including an undone position,
  • no cloud/Internet inference, telemetry, automatic web retrieval, remote runtime assets, shell/MCP/general plugin execution,
  • LAN inference is distinct from LAN exposure of the storyteller UI/API; the latter is not required for v1,
  • future local image/video/audio/TTS/STT support remains optional and decoupled from the story engine.

Still open, and deliberately so

These do not block the architecture and are not v1 requirements:

  • comparative recommendation of narrator/state models for real users,
  • multi-hour/100-turn long-run behavior,
  • detailed concurrency behavior beyond the single-user turn lock,
  • actual future image/video/TTS/STT provider integration,
  • abandoned-history cleanup UI/policy (not required in v1).

Where the work stands

Phase 0 research and spikes         COMPLETE
Architecture/fork decision          COMPLETE
Planning package approved           COMPLETE
        |
        v
Milestone M1                        COMPLETE (2026-09-02)
  fork + offline baseline           archive/milestone-reports/M1-*.md
        |
        v
Milestone M2                        COMPLETE (2026-09-02)
  local-only surface + endpoint     archive/milestone-reports/M2-*.md
  policy
        |
        v
Milestone M3                        COMPLETE (2026-09-03)
  non-destructive undo/redo,        archive/milestone-reports/M3-*.md
  active-head export                and ADR 012
        |
        v
Milestone M4                        COMPLETE (2026-09-03)
  named Save Points                 reports/M4-IMPLEMENTATION-REPORT.md
        |                           browser verification: PASS (M3 + M4)
        v
M5-M11, one at a time               see BUILD-MILESTONES.md

Stop Rule

One milestone at a time. Do not begin a milestone before its brief exists.

No M5 brief has been prepared. Writing one is the current action, informed by the M4 report's §U readiness assessment and by the note BUILD-MILESTONES.md attaches to M5 — in particular that M4 added 55 tests using the inherited world-state values as deterministic instrumentation, which M5 must move rather than delete.

No conditions remain open on M1-M4. The browser smoke condition that M3 and M4 both carried was satisfied at M4 closeout: a real Firefox exercised the rendered DOM for both milestones' controls, 44/44 checks passing. The M3 report's §M.2 and the M4 report's §M record the condition as it stood; the M4 report's §W records it closed.

What each milestone closeout corrected

These tables are the audit trail: what implementation evidence forced back into the planning package, milestone by milestone. VERSION.md narrates the same changes.

Post-M3 corrections applied (2026-09-03)

M3's review recommended planning changes and, following the M2 pattern, reported rather than applied them. All are now applied, together with the closeout work the milestone itself required:

Document Correction
DECISIONS/012-active-head-non-destructive-history.md New ADR. The architecture selected to implement ADR 005: head stored not derived, one capped read path, one movement mechanism, state from the node, divergence on first write below the head, Redo decided by the lineage, advisory disposition metadata, and the head as an exported decision.
STORY-BRANCH-SEMANTICS.md §5 Undo crosses fork points and continues to the campaign opening. The old refusal was a consequence of destructive deletion, not a product decision.
STORY-BRANCH-SEMANTICS.md §10 Switching which take is live is refused while a later story is off screen, with the two resolutions the user has.
STORY-BRANCH-SEMANTICS.md §14A New. In-place editing before §14-15 exist: refuse when story descends from the turn and is not on screen. States explicitly that the full narrator-edit requirement stands and is completed in M5.
TECHNICAL-DESIGN.md §8.7, §9.1 New. The implemented active-head model and bundle behaviour, recorded as fact.
TECHNICAL-DESIGN.md §10.4 Constraint from M3: the snapshot half of the hybrid state model is a requirement, or head movement becomes proportional to campaign length.
DATA-MODEL.md §4, §5, §29 The head as campaign-stored rather than derived; the branch disposition as implemented and deliberately advisory; the export as carrying a chosen position.
BUILD-MILESTONES.md M3 Marked COMPLETE, with inherited capabilities, the open browser condition, and carried debt.
BUILD-MILESTONES.md M4 Note: a Save Point is a durable pointer; restore by reusing M3's head movement rather than building a second restore path.
BUILD-MILESTONES.md M5 Note: keep state efficiently recoverable at a position; move the test instrumentation rather than the assertions; complete the narrator edit.
V1-ACCEPTANCE-TESTS.md D03, D10, I07, L01 D03's result recorded as a full pass; D10's milestone ownership stated without weakening any pass condition; I07's pre-M3 bundle clause added; the apparent L01/A05 conflict resolved.
README.md Corrected to describe the current local-only single-user application. The scripting, accounts, analytics, hosted-demo, cloud-provider, Postgres and Render material described subsystems M2 removed.

SPECIFICATION.md and SECURITY-THREAT-MODEL.md were deliberately not changed. M3 altered no product requirement and touched no path in the threat model.

Post-M2 corrections applied (2026-09-03)

M2's review recommended six planning changes and reported rather than applied them. All six are now applied, plus three additions drawn from the same evidence:

Document Correction
SECURITY-THREAT-MODEL.md New §10A records the inference endpoint policy as implemented — address allowlist, enforced on save and before every request, TLS never traded against it — with both residual limits stated. §71A item 5 marked resolved; §77 notes the required defaults are now met.
TECHNICAL-DESIGN.md §5.1 Items 3 and 4 marked done; all five hardening items are now resolved.
TECHNICAL-DESIGN.md §5.2 New: the M1/M2 production architecture recorded as fact — SQLite, Ollama-only, loopback storyteller, trusted-LAN inference accepted, public endpoints refused.
TECHNICAL-DESIGN.md §18.1 New wiring rule from the M2 regressions: test a real consumer path when removing a setting, and prove a new setting reaches its component.
DECISIONS/011-local-inference-endpoint-policy.md New ADR. Address-based allowlist over hostname matching, deny by default, checked twice, mandatory TLS — with the ipaddress-classification finding as the reason the CIDRs are spelled out.
BUILD-MILESTONES.md M2 Marked COMPLETE with the capabilities it delivered and the debt it carried forward.
BUILD-MILESTONES.md M5 Note: eight rollback tests now use the world-state engine as instrumentation, not as endorsement; move the instrumentation when M5 replaces the protocol, and rework rather than delete those tests.
BUILD-MILESTONES.md M6 Note: background memory failure must be observable, at least one real provider-construction path must be tested, and derived-memory failure must not corrupt accepted story state.
V1-ACCEPTANCE-TESTS.md H10 Strengthened: a wildcard origin must be rejected at startup, and an unknown /api/... path must 404 rather than returning the SPA with HTTP 200.
V1-ACCEPTANCE-TESTS.md H12 New. Inference endpoint enforcement, including the defence-in-depth case: a public endpoint written into the database behind the settings API must still be refused at request time.

SPECIFICATION.md was deliberately not changed. M2 altered no product requirement; it removed capability the specification never asked for.

Post-M1 corrections applied (2026-09-02)

Implementation evidence contradicted or under-specified six places in this package, and a seventh was added on review. All seven are now corrected:

Document Correction
DECISIONS/002-ollama-only-v1.md New section: a trusted-LAN Ollama may be HTTPS with a private CA; verify against the OS trust store; full certificate and hostname checking; no bypass option.
DECISIONS/004-local-only-production.md New Testing Consequence: offline tests need a fresh cache and no route out. Vendored runtime artifacts should be integrity-verifiable.
V1-ACCEPTANCE-TESTS.md A05 Pass conditions reworded around accepted history; explicit note that the user's submitted text is deliberately retained.
V1-ACCEPTANCE-TESTS.md A06 Now requires a real second machine and an HTTPS endpoint with a locally issued certificate; a plain-HTTP LAN test is no longer sufficient evidence.
V1-ACCEPTANCE-TESTS.md §3 Record CPU/GPU/RAM: cold model load on a CPU-only host exceeded the inherited 120 s timeout.
BUILD-MILESTONES.md M1 marked COMPLETE with the capabilities it delivered; M2's endpoint-policy line reframed from inventing trusted-LAN support to narrowing it.
TECHNICAL-DESIGN.md §5 Runtime boundary restated: the storyteller is loopback-only, inference may be same-host or trusted-LAN, and the two are independent. Adds the TLS/private-CA rule.