Closes M4. The review's three findings are fixed, the durability rule the specification always implied is now enforced, and M3's and M4's browser behaviour has been verified in a real browser for the first time. B-1 -- the Save Point list was an N+1 that loaded whole Action rows, narration included, to answer "does a row exist here". It is now one bulk two-column coordinate query plus one lineage: 53 SELECTs for 25 Save Points became 5, and the count no longer grows with the list. The clause is an OR of exact (branch, depth) pairs rather than two IN lists, because the cross product would report a Save Point resolved on the strength of another one's depth existing on this one's branch. A test builds exactly that trap. B-2 -- reclassified during closeout from "missing warning" to a behaviour defect, and fixed as one. STORY-BRANCH-SEMANTICS §19 says a named checkpoint remains until explicitly deleted, and §28 already required future cleanup to retain checkpoint-referenced paths; a cascade that silently removed Save Points with a branch violated both, and a warning would only have documented the violation. A branch a Save Point names can no longer be deleted. The request is refused with the offending Save Points named, the user deletes them explicitly -- which deletes no story -- and the branch then goes. The scope is the subtree, because deleting a branch takes its descendants. Both delete controls disable and explain. Recorded as a new §19.1; models.py, TECHNICAL-DESIGN §8.8 and DATA-MODEL §8 had all recorded the cascade as the rule and now record the refusal. An earlier pass in this same closeout had kept the cascade and added a warning. That was the wrong fix and its tests were replaced rather than left standing, since they pinned the defect. B-3 -- the D11/L03 automation never left one process, so it could not distinguish durable state from a live Python object. It now spawns real server processes, kills the first, and reads the campaign back with the second. C-5 -- creating a Save Point takes the campaign's turn lock. "Save where I am" has to name one committed position, and the head is what a turn in flight is about to move. Rename and Delete deliberately do not take it. The architecture is untouched: a Save Point is still name + note + (branch, depth), and restore is still coordinate -> head.move_to_node -> head.move_to -> attempts.restore_state. No second restore path, no state copied into a checkpoint, no fork on restore. Browser verification -- the first in this project, and it covers both milestones. Firefox 154.0.1 through geckodriver over the W3C WebDriver protocol, driving the rendered DOM: 47/47 checks, twice, on independent databases, no console errors. M3's Undo/Redo enable states, transcript movement, Retry and the take pager, divergence retiring Redo; M4's whole Save Point lifecycle, both confirmations, and the new branch-delete refusal including its recovery. No dependency was added: the WebDriver client is stdlib HTTP. No application defect was found by the browser. Four failures occurred, all in the harness -- a wrong SPA route, a wait comparing transcript length when the empty-story placeholder is longer than the first turn, a fixture deleting the branch it was reading, and a reload assertion that sampled once instead of waiting. The last was checked against the app before being called a harness bug. Tests: 698 backend pass (was 680), 60 M4, 94 M3 history, 66 export/ migrations, 93 security/local-only. Frontend lint and build clean, Docker build clean, loopback binding unchanged. No assertion weakened, no skip added. Planning: STORY-BRANCH-SEMANTICS §19.1 is the only behavioural change and it strengthens §19. V1-ACCEPTANCE-TESTS records D11-D14, I04, L03 and the E-series, keeping automated, live-runtime and browser evidence distinct, and weakens no pass condition. DATA-MODEL records the coordinate with the retry measurement that settles it. BROWSER-UX-SPEC rules for Moment over Turn. BUILD-MILESTONES marks M4 COMPLETE, closes M3's browser condition, and lists what M5 inherits. VERSION adds v2.6. No new ADR: ADR 005 already decides that history is preserved rather than overwritten, and §19.1 is that decision applied to checkpoint-referenced history. M4 is closed. M5 may now be briefed; it has not been started. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PWU4gTfLYY6Qq9U7aa9Qw2
16 KiB
Planning Package Version
- Package: Adventure Storyteller Planning Package v2.6
- Revision date: 2026-09-03
- Status: Phase 0 complete; architecture selected; Milestones M1-M4 implemented and accepted; M5 is next to brief.
v2.6 — M4 Closeout (2026-09-03)
M4 is accepted. Its review returned PASS WITH CORRECTIVE WORK REQUIRED; the corrective work is done, and the browser condition that M3 and M4 both carried is closed.
The three review findings, fixed:
- B-1 — the Save Point list was an N+1. It resolved each Save Point with its
own query and loaded whole
Actionrows, narration included, to answer "does a row exist here". It is now one bulk two-column coordinate query plus one lineage computation: 53 SELECTs for 25 Save Points became 5, and the count no longer grows with the list. Guarded by three tests, including one proving the coordinate is matched as a pair — anIN-list version would report a Save Point resolved because another branch has a live row at the same depth. - B-2 — deleting a branch silently deleted its Save Points. Fixed as a
behaviour defect rather than a missing warning, because
STORY-BRANCH-SEMANTICS.md§19 says a named checkpoint remains until explicitly deleted and §28 already required future cleanup to retain checkpoint-referenced paths. A branch a Save Point names can no longer be deleted. The request is refused with the offending Save Points named; the user deletes them explicitly, which deletes no story, and the branch then goes. Both delete controls disable and explain. Recorded as a new §19.1. - B-3 — the D11/L03 automation never left one process. A new module spawns real server processes, kills the first, and reads the campaign back with the second.
Also fixed (review §S C-5): creating a Save Point now takes the campaign's turn lock, so "save where I am" cannot read a head a turn in flight is about to move. Rename and Delete deliberately do not take it, and a test pins that decision.
Real-browser verification — the first in this project. A Firefox 154.0.1 driven through geckodriver over the W3C WebDriver protocol exercised the rendered DOM for both milestones: 44/44 checks passed, no console errors. It covered M3's Undo/Redo enable states, transcript movement, Retry and the take pager, and divergence retiring Redo; and M4's whole Save Point lifecycle including both confirmations and the new branch-delete warning. The outstanding M3 browser condition is therefore closed as well. No dependency was added to the repository: the WebDriver client for the run was written against stdlib HTTP.
Also corrected, found while fixing B-2: models.py, TECHNICAL-DESIGN.md
§8.8 and DATA-MODEL.md §8 all described the cascade as the durability rule.
They now describe the refusal, and record that checkpoints.branch_id's cascade
survives as referential integrity that the application no longer reaches.
Documents corrected by this closeout:
V1-ACCEPTANCE-TESTS.mdrecords results for D11-D14, I04, L03 and the E-series, and states that the browser-level condition is satisfied. No pass condition was weakened — and D11/L03 now note that the automation crosses a genuine OS process boundary, which is the standard later milestones should meet.DATA-MODEL.md§8 records the coordinate as implemented, with the retry measurement that settles coordinate-versus-turn-id, and three decisions that were previously implicit: names are not unique, several Save Points may name one position, and the list is newest-created first.STORY-BRANCH-SEMANTICS.mdgains §19.1 — a checkpoint protects the history it names. This is the only behavioural specification change in the closeout, and it strengthens §19 rather than weakening anything.BROWSER-UX-SPEC.md§25 rules for the implemented vocabulary: Moment N, not Turn N, because the branch panel and tree overlay already count in moments. Vocabulary only; no behaviour changes.BUILD-MILESTONES.mdmarks M4 COMPLETE, records the fixes and the browser result, and warns M5 that the instrumentation to move is now 55 tests.README.mdrecords M1-M4 accepted and M5 as next to brief.PROJECT-SOURCES.mdandproject-sources.txtpoint at the current report;project-sources.txtstill named the archived M3 report and was corrected.
Report rotation happened in the reporting pass that preceded this closeout:
M3-IMPLEMENTATION-REPORT.md moved to archive/milestone-reports/ as a pure
rename, and reports/ now holds M4's report, whose §W is this closeout's
evidence record.
No new ADR. ADR 012 already decides the architecture, and the corrective work
forced no new architectural decision. SPECIFICATION.md,
STORY-BRANCH-SEMANTICS.md, SECURITY-THREAT-MODEL.md, CONTEXT-AND-MEMORY.md,
IMPORTED-KNOWLEDGE-DESIGN.md and ADRs 003, 005 and 012 are unchanged.
M5 readiness: ready. Save Points store no state and no checkpoint code reads
any, so M5 can change what a snapshot contains without touching what a Save Point
is — provided it keeps state recoverable at a position without replay
(TECHNICAL-DESIGN.md §10.4).
v2.5 — M4 Implementation (2026-09-03)
M4 added durable named Save Points. This revision records only what the implementation established as fact; no product requirement changed, and the milestone is not marked accepted — its review has not been written.
TECHNICAL-DESIGN.mdgains §8.8 and §9.2: the Save Point as a name plus a coordinate holding no story, restore as head movement with a bounds check, the rule that the branch half of the head moves only when the coordinate is off the path being read, restore never forking, and the bundle carrying Save Points independently of the head.DATA-MODEL.md§8 records the pointer as implemented —(branch, depth)rather than a turn id, with the reason: one coordinate holds every attempt at a turn and exactly one is live, so a coordinate follows a retry where a row id would pin a superseded take. §29 records the checkpoints in the export.BUILD-MILESTONES.mdM4 gains a status block: what shipped, the one architectural decision the milestone had to make and why it needed no new ADR, the test count, and the outstanding browser condition.README.mddescribes Save Points as a user-facing capability.
No ADR was created. ADR 012 already decides the architecture M4 needed —
restore reuses active-head movement — and a table is not a decision. The one
question ADR 012 does not answer, whether restore moves the branch half of the
head, is that same mechanism applied to a coordinate ADR 012 already defines;
TECHNICAL-DESIGN.md §8.8 records the answer rather than a new ADR asserting it.
SPECIFICATION.md, SECURITY-THREAT-MODEL.md, STORY-BRANCH-SEMANTICS.md and
V1-ACCEPTANCE-TESTS.md are unchanged. M4 altered no product requirement, added
no outbound path, and implemented the checkpoint semantics
STORY-BRANCH-SEMANTICS.md §18-25 already specified rather than amending them.
The browser smoke test remains unperformed, now for both M3 and M4. No
session has had a usable browser. See BUILD-MILESTONES.md M3 and M4.
v2.4 — Documentation Consolidation (2026-09-03)
No product requirement, architecture decision or milestone status changed in this revision. It reorganises the documentation so that a new coding agent can tell authoritative material from evidence at a glance.
planning/archive/is created and is non-authoritative by declaration (archive/README.md). It holdsphase0/— the research that chose AI-DnD —milestone-reports/— the completed M1 and M2 reports — anddecisions/, which now holds ADR 008, the Phase-0-before-build process gate that Phase 0 satisfied. ADR numbering continues from 012; 008 is not reused.planning/reports/now holds only the current milestone's report,M3-IMPLEMENTATION-REPORT.md, because M4 planning has to consult it. It moves to the archive when M4's report replaces it.- The Phase 0B execution prompts and handoff/status/summary documents
(
CODEX-HANDOFF-NOTE.md,PHASE-0B-CODEX-BRIEF.md,PHASE-0B-CODEX-HANDOFF.md,PLANNING-UPDATE-SUMMARY.md) and the Phase 0A discovery and triage reports were deleted: intermediate working documents whose conclusions all reached the two recommendation reports, and which remain in Git history. - Upstream AI-DnD's inherited
plan/build log anddocs/project site (guides, generated HTML, screenshots) were deleted. They documented a hosted, scripted, multi-user product with accounts — every screenshot showed a Scripts tab and a Sign up button — which M2 removed. Both trees remain in Git history and in upstream. README.md,DEVELOPMENT.mdandPROVENANCE.mdare corrected where they pointed at the removed trees or described removed capability as present.DEVELOPMENT.md's "things M1 did not touch" section had gone stale at M2 and now says what is actually still inherited.planning/README.mdis rewritten as the documentation index: current milestone, the three-way active/ADR/archive split, the authority order, reading order, where reports live, and what comes next. The milestone correction tables are preserved unchanged.- New:
planning/PROJECT-SOURCES.mdandplanning/project-sources.txt, the manifest of files to upload as ChatGPT Project Sources.
v2.3 — Post-M3 Closeout (2026-09-03)
M3 replaced destructive Undo with a stored active head. Its review is
archive/milestone-reports/M3-IMPLEMENTATION-REPORT.md, which is also M3's primary evidence
record — no separate baseline report was produced — and whose §W records this
closeout.
In summary:
- the architecture is recorded as ADR 012 — Active-Head Non-Destructive History: the head is stored rather than derived, every read of the story is capped at it in one place, one mechanism moves it, state comes from the node rather than from a replay, the first write below a moved-back head is the divergence, and Redo is decided by the lineage rather than by a flag. ADR 005 is unchanged: it states the product requirement, and ADR 012 states the architecture chosen to implement it,
- two history semantics are ratified in
STORY-BRANCH-SEMANTICS.md: Undo crosses fork points to the campaign opening (§5), and the system refuses to switch which take is live while a later story is off screen (§10), - a new §14A records the interim in-place-editing rule — refuse when story descends from the turn and is not on screen — and states explicitly that §14-15's full narrator-edit requirement stands and is completed in M5,
TECHNICAL-DESIGN.mdgains §8.7 and §9.1 recording the implemented model and bundle behaviour as fact, and a constraint on §10.4: the snapshot half of the hybrid state model is a requirement, because head movement must not become proportional to campaign length,DATA-MODEL.mdrecords the head as campaign-stored, the branch disposition as implemented and deliberately advisory, and the export as carrying a chosen position rather than a derived one,BUILD-MILESTONES.mdmarks M3 complete, states the one outstanding condition (the browser smoke test), tells M4 to reuse M3's head movement rather than build a second restore path, and gives M5 three constraints,V1-ACCEPTANCE-TESTS.mdrecords D03's full pass, states D10's milestone ownership without weakening any pass condition, adds I07's pre-M3 bundle clause, and resolves the apparent L01/A05 conflict,README.mdis corrected to describe the current local-only single-user application rather than the upstream hosted one.
SPECIFICATION.md and SECURITY-THREAT-MODEL.md are unchanged: M3 altered no
product requirement and touched no path in the threat model.
v2.2 — Post-M2 Closeout (2026-09-03)
M2 removed the hosted, cloud, account and scripting surface and added the
inference endpoint policy. Its review recommended six planning changes and
reported rather than applied them; all six are applied in this revision, listed
in README.md § Post-M2 corrections applied, with the evidence in
archive/milestone-reports/M2-BASELINE-REPORT.md and archive/milestone-reports/M2-IMPLEMENTATION-REPORT.md.
In summary:
- the inference endpoint policy is recorded as implemented — an address
allowlist of explicit local-network CIDRs, every resolved address checked,
enforced when settings are saved and again before every outbound request, with
TLS verification never traded against it (new ADR 011,
SECURITY-THREAT-MODEL.md§10A), - its two residual limits are stated rather than mitigated: a hostile host already on the trusted LAN, and the DNS-rebinding interval between the policy's resolution and the client's connection,
TECHNICAL-DESIGN.md§5.1 items 3 and 4 are resolved, and a new §5.2 records the M1/M2 production architecture as fact,- a wiring rule is added (§18.1): removing a setting requires testing a real consumer path, and adding one requires proving it reaches its component — M2 shipped two defects behind a 604-test green suite because the tests at that boundary were mocks,
BUILD-MILESTONES.mdrecords M2 complete, warns M5 that eight rollback tests use the world-state engine as instrumentation rather than as architecture, and requires M6 to make background memory failure observable,- the security acceptance contract is strengthened: H10 now names the
wildcard-origin and
/api404 conditions, and new H12 covers inference endpoint enforcement including the database-edited-behind-the-API case.
SPECIFICATION.md is unchanged: M2 altered no product requirement. Nothing in
the architecture selected in v2 was reversed.
v2.1 — Post-M1 Corrections (2026-09-02)
M1 implementation evidence contradicted or under-specified parts of v2. The
corrections are recorded in the documents themselves and listed in
README.md § Post-M1 corrections applied; the evidence behind them is in
archive/milestone-reports/M1-BASELINE-REPORT.md and archive/milestone-reports/M1-IMPLEMENTATION-REPORT.md.
In summary:
- a trusted-LAN Ollama may be HTTPS with a privately issued certificate;
clients verify against the operating system's CA store, with full certificate
and hostname verification and no bypass option (ADR 002,
TECHNICAL-DESIGN.md§5, A06), - offline claims require a fresh cache and no route out to be evidence at all, and vendored runtime artifacts should be integrity-verifiable (ADR 004),
- A05's invariant is about accepted history; the user's submitted text is deliberately retained on a failed turn,
- A06 requires a real second machine and an HTTPS endpoint; a plain-HTTP LAN test is no longer sufficient evidence,
- the standard test environment records CPU/GPU/RAM, because cold model load on a CPU-only host exceeded the inherited 120 s client timeout,
BUILD-MILESTONES.mdrecords M1 as complete and reframes M2's endpoint work as narrowing an existing capability rather than inventing it,SECURITY-THREAT-MODEL.md§53 distinguishes inbound TLS (still deferred) from outbound certificate verification (required, done in M1).
Nothing in the architecture selected in v2 was reversed.
v2 — Post Phase 0B Revision (2026-09-01)
This v2 package supersedes the earlier planning package produced before the final Phase 0B review and the trusted-LAN Ollama deployment clarification.
Key v2 changes include:
- AI-DnD selected as the production base at the pinned Phase 0B commit.
- Non-destructive head-cursor Undo/Redo design selected.
- Explicit typed/absolute narrative-state events selected for production state handling.
- Imported knowledge separated from AI-DnD Story Cards.
- Trusted-LAN Ollama inference supported in v1 while the storyteller UI/API remains loopback-bound by default.
- Offline first-use dependencies and runtime remote assets identified as M1 hardening work.
- Production implementation divided into milestones M1-M11.
Historical Phase 0 prompts/reports are retained as evidence and should not be treated as current implementation instructions unless a current milestone prompt explicitly refers to them.