Jesse.Markowitz/station-master
1
0
Fork 0
Code Issues 4 Pull Requests Actions Packages Projects Releases Wiki Activity

v0.8.0.8 — a played train does not come back; a discarded one does

Browse Source 
Jesse's ruling on the question v0.8.0.7 filed: once a regularly scheduled train has
been played its number is on the timetable, so putting it back into a reshuffled
deck to be played again makes no sense. The same card sitting in a discard pile was
never played and its slot is still open, so it should come back. An Extra is a
single run rather than a standing slot, so a played one is free to run again.

The test is therefore WHERE the card is, not only what it is — which is worth
writing down, because it is exactly the rule a later tidy-up would simplify into
filtering by kind everywhere.

And the duplicate that started it: trainScheduled was pushing a synthetic
train-<number> into the Salvage Yard beside the real card cardPlayed had already
put there — four scheduled trains left eight entries in a pile holding four cards.
Nothing read it, it inflated the depth, it displayed as "a card", and it would have
been swept into the draw deck to be drawn as an id with nothing behind it. Removed,
which retires the phantom-id class rather than papering over it, so v0.8.0.7's
cardName resolver for it goes too.

Games in progress resume: no predicate changed its answer, and a draw is a draw
whatever is on top. What differs is the Yard's depth, which was double-counting,
and what a reshuffle recovers — and reshuffles are effectively unreachable, with
zero seen across eight games driven to 4000 moves.

Closes #23.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X6cF1iYvJ1kNmzYBzu4QX6
This commit is contained in:
Jesse.Markowitz
2026-09-10 07:19:47 -04:00
co-authored by Claude Opus 5
parent d0e5091824
commit 072029b1f7
6 changed files with 140 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/web.test.ts
-28
View File
@@ -3647,34 +3647,6 @@ describe('the Day rolling over says so (Gitea#10)', () => {
);
});
it('names the train on top of the Salvage Yard, instead of "a card"', () => {
/**
* The Salvage Yard is a FACE-UP pile and its tile reads the top card — but `trainScheduled`
* pushes a synthetic `train-<number>` id rather than the id of the card that was played
* (`apply.ts`), so there was nothing in `s.cards` to look up and the tile said "a card". A train
* is scheduled several times a Day, so that id is on top most of the time: the pile was face up
* and had nothing to say. Jesse, 2026-09-10: *"why is salvage deck not face up. I should see the
* card played onto salvage."*
*/
const s = createEngineGame({
id: 'salv',
seed: 5,
config: {
mode: 'competitive', days: 5, minCombinedRevenue: 60,
maxCollisionsPerDay: 0, maxCollisionsTotal: 0, pvpCardsAllowed: false,
optionalRules: { reducedVisibility: false, employeeRotation: false, emergencyToolbox: false },
},
playerNames: ['Joe', 'Bot 1'],
});
s.decks.salvageYard.push('train-13');
const f = snapshot(s, [], null);
assert.equal(f.salvage.top, 'Train 13', 'a scheduled train on the pile must be named');
const html = pilesHtml(f);
assert.ok(html.includes('Train 13'), `the Salvage tile does not name the train:\n${html}`);
assert.equal(html.includes('>a card<'), false, 'the face-up pile still says "a card"');
});
it('lights only the pile a watched move touched', () => {
const s = createEngineGame({
id: 'piles2',