configWith let the day count and the Revenue floor disagree

minCombinedRevenue fell back to SOLO_CONFIG's constant — the floor for a
FIVE-Day game — whatever days said. configWith({ days: 1 }) asked a
one-Day game to clear 15, which a full five-Day game averages barely
half of; configWith({ days: 10 }) asked for that same 15. It derives
from the days it was given now.

Not a live fault: createLocalSession is the only caller and the page
always writes the floor itself, so no dealt game was ever wrong. Found
by a throwaway probe that passed only days — which is how the next
caller would reach for it. Unchanged at the default day count, since
SOLO_CONFIG's floor is this same formula at DEFAULT_DAYS.

Stays in the unshipped v0.7.9 per Jesse — no version bump for the next
several fixes. 873 tests pass, three new.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AdG46Ja2PEDBkpqiDazMoX
This commit is contained in:
Jesse.Markowitz
2026-08-30 01:51:11 -04:00
co-authored by Claude Sonnet 5
parent e035dda5a3
commit 45cf521a40
3 changed files with 61 additions and 3 deletions
+17 -2
View File
@@ -134,10 +134,25 @@ export type NewGameOptions = {
/** The same config with the New Game dialog's answers in it. */
export function configWith(opts: NewGameOptions): GameConfig {
const days = opts.days ?? SOLO_CONFIG.days;
return {
...SOLO_CONFIG,
days: opts.days ?? SOLO_CONFIG.days,
minCombinedRevenue: opts.minCombinedRevenue ?? SOLO_CONFIG.minCombinedRevenue,
days,
/**
* DERIVED FROM THE DAYS ACTUALLY IN PLAY, not from `SOLO_CONFIG`'s five-Day constant.
*
* It fell back to the constant until 2026-08-30, so `configWith({ days: 1 })` asked a one-Day
* game to clear **15** — a floor a five-Day game averages barely half of — and
* `configWith({ days: 10 })` asked for the same 15 a five-Day game does. The two fields silently
* disagreed, which is the one thing a "build me a config" helper must not let happen.
*
* Not a live fault when it was found: `createLocalSession` is the only caller, and the page
* always writes `minCombinedRevenue` itself (`solitaireDefaults` re-derives it from the preset).
* Found by a throwaway probe that passed only `days` — which is exactly how the next caller
* would use this. At the default day count the answer is unchanged, since `SOLO_CONFIG`'s own
* floor is this same formula at `DEFAULT_DAYS`.
*/
minCombinedRevenue: opts.minCombinedRevenue ?? collectiveRevenueFloor(1, days),
maxCollisionsPerDay: opts.maxCollisionsPerDay ?? SOLO_CONFIG.maxCollisionsPerDay,
maxCollisionsTotal: opts.maxCollisionsTotal ?? SOLO_CONFIG.maxCollisionsTotal,
optionalRules: { ...SOLO_CONFIG.optionalRules, ...(opts.optionalRules ?? {}) },