v0.6.2 — an Extra starts where you put it, a train card is never discarded
Three more from the v0.4.9e gameplay-testing round, filed as Gitea issues, plus two bugs found underneath them. Gitea#2 is diagnosed but NOT fixed: it needs a ruling, and the reasoning is in TODO.md under Play Balance. GITEA#4 — AN EXTRA STARTS WHERE THE PLAYER PUTS IT. Only one Division Point was ever offered, chosen by number parity. The number no longer decides an Extra's direction — the start does, which supersedes the recorded ruling that "the number decides, like everything else on the timetable". The two cannot both hold: an odd, westbound Extra placed at the WEST end would leave the Division on its first move having crossed nothing, and be paid for the run. Either end now runs the train away from itself; at an Interchange or a Control Point the player picks the direction. The Interchange start is a YARD, off the running line, which is what makes the Superintendent clause work: placing it can never force a collision, a guaranteed one holds it there for another Stage, and a potential one is the Superintendent's to rule on — exactly evaluateClearance's `blocked` and `ask`, so nothing new decides collisions. Where an Extra may start is now a house rule (divisionPointsOnly / ownOffice / anyOffice, defaulting to what the engine already did). The legacy `atSeat` intent field still replays as it always meant. FOUND UNDERNEATH IT: an Extra started away from a Division Point ran empty. isBeingMadeUp tested position alone, so the Control Point start has been shipping since it was added with a train that could never be given a consist. Found by playing it, not by the tests, which had only asserted where the tray landed. FOUND UNDERNEATH IT: collide left the wrecks on the card. Destroyed trains kept their Transit entries, and evaluateClearance counts every transit as an occupant, so one rear-end collision permanently poisoned that Mainline card for every later train. THE MAINLINE CARDS WERE ROLLED, NOT DEALT — drawn from the nine types with replacement, so a Division could hold two Interchanges and Plains carried the weight of a card printed once. "An Extra may start at the Interchange if one is on the board" only reads as a rule if the board holds at most one. Now dealt from the printed deck without replacement, verified over 1600 deals. This re-deals every seed: the published replays were re-recorded, and the saved games in docs/ are retired too — two of those were already dead before this release and nobody had noticed. GITEA#6 — A TRAIN CARD IS NEVER DISCARDED, Timetabled and Extra alike. The forced play needed no mechanism: nothing discardable plus a hand over the limit leaves exactly one legal way to end the turn, and playing a train is unconditionally legal, so the corner cannot trap anyone. The bot needed no rule either. 400/400 games finished, revenue unmoved, trains scheduled 1.2 -> 1.3. The player is told on the card and on the button. GITEA#7 — COACH COUNTS. 1/2 Crack Limited 3 -> 2, 5/6 The Sparrow 2 -> 3. A change to the cards, so Trains3.pdf and the transcription keep the original numbers with a footnote while content.ts and the Home Deck reference carry what the game plays. CONTENT.TS COMMENT PASS — no data changed, only comments. Four were factually wrong, including an office table naming counts doubled long ago and a pointer to a DEALT_DECK_SIZE that has never existed. Every Enhancement row cited its implementation by line number and every citation had rotted; they name functions now. Card counts came out of the comments, since they move with play balance; source-sheet figures and dated measurements stayed. TODO.md gains an item for a card reference generated from content.ts, in six sections, so the documentation cannot disagree with the game. 715 tests pass, tsc clean, site builds.
This commit is contained in:
@@ -22,6 +22,7 @@ import {
|
||||
deckComposition,
|
||||
isFreightHouse,
|
||||
lengthProfile,
|
||||
MAINLINE_DECK,
|
||||
mainlineCardCount,
|
||||
nextOfficeTier,
|
||||
officeProfile,
|
||||
@@ -413,6 +414,42 @@ describe('game setup (component 2)', () => {
|
||||
}
|
||||
});
|
||||
|
||||
it('deals the Mainline cards from the printed deck, without replacement', () => {
|
||||
/**
|
||||
* `buildDivision` drew uniformly from the nine card TYPES with replacement, so a Division could
|
||||
* be dealt two Interchanges (or two Tunnels), and Plains — printed twice in the deck — carried
|
||||
* the same weight as cards printed once. That became a rules question rather than a flavour one
|
||||
* when an Extra gained the right to start "at the Interchange if one is on the board" (§7): the
|
||||
* board has to hold at most one for that to mean anything.
|
||||
*
|
||||
* Swept over many seeds because a single deal cannot tell a deck from a die.
|
||||
*/
|
||||
const seen = new Map<string, number>();
|
||||
for (let seed = 0; seed < 400; seed++) {
|
||||
for (const players of [1, 2, 3, 4]) {
|
||||
const g = createGame({
|
||||
id: 'deck', seed,
|
||||
config: players === 1 ? solitaireConfig : { ...solitaireConfig, mode: 'competitive' },
|
||||
playerNames: Array.from({ length: players }, (_, i) => `P${i}`),
|
||||
});
|
||||
const cards = g.division.nodes.flatMap((n) => (n.kind === 'mainline' ? [n.card] : []));
|
||||
assert.equal(cards.length, mainlineCardCount(players));
|
||||
const counts = new Map<string, number>();
|
||||
for (const c of cards) {
|
||||
const n = (counts.get(c) ?? 0) + 1;
|
||||
counts.set(c, n);
|
||||
seen.set(c, (seen.get(c) ?? 0) + 1);
|
||||
// Plains is the one card printed twice; nothing else may be dealt twice at all.
|
||||
assert.ok(n <= (c === 'plains' ? 2 : 1), `${c} dealt ${n} times at seed ${seed}`);
|
||||
}
|
||||
}
|
||||
}
|
||||
// Every card in the deck reachable, so the deal is not quietly missing one.
|
||||
for (const kind of new Set(MAINLINE_DECK)) {
|
||||
assert.ok((seen.get(kind) ?? 0) > 0, `${kind} was never dealt in 400 seeds`);
|
||||
}
|
||||
});
|
||||
|
||||
it('opens with the whole railroad as one Subdivision', () => {
|
||||
// §8 — every Office is a Whistle Post, which is not a Control Point.
|
||||
const g = newSolitaireGame();
|
||||
|
||||
Reference in New Issue
Block a user