A game you come back to has not begun
Reported by Jesse, 2026-08-30: "when you are continuing the saved game out of that screen, do not post a message that says 'The game has begun.' … it needs to say 'The game has resumed.'" A restored game draws exactly like a dealt one — mid-Day, mid-phase, with a log already several turns deep — and solitaire said nothing at all to tell the two apart. It flashes "The game has resumed — Day 3, Stage 7" now, on both ways back in: the setup screen's Continue saved game, and a bare reload that restores the save. THE SAME LINE WAS WRONG ON THE MULTIPLAYER SIDE, IN THE OTHER DIRECTION. noteFirstFrame guards on firstFrameSeen, which is per page-load — so re-entering a game this browser already held a seat in, by reloading mid-game or picking it out of the lobby's list, announced that the game had BEGUN to somebody who had been playing it for an hour. beginRemote carries whether this is a rejoin now, and the line reads "resumed" when it is. Both halves are pinned, including that a brand-new game does not claim to be a resume — an announcement that fires either way says nothing. Stays in the unshipped v0.7.9. 878 tests pass, eleven new. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AdG46Ja2PEDBkpqiDazMoX
This commit is contained in:
co-authored by
Claude Sonnet 5
parent
788e5f2eec
commit
bb1b661211
+20
-1
@@ -235,6 +235,25 @@ Three more from Jesse reading the two screens side by side.
|
||||
train may be discarded" — ships **on** in all four types, not just Co-op. The note now says only
|
||||
what is true of all of them: "Each one changes how the game plays."
|
||||
|
||||
### A game you come back to has not begun
|
||||
|
||||
Jesse, 2026-08-30: "when you are continuing the saved game out of that screen, do not post a message
|
||||
that says 'The game has begun.' … it needs to say 'The game has resumed.'"
|
||||
|
||||
A restored game draws exactly like a dealt one — mid-Day, mid-phase, with a log already several turns
|
||||
deep — and **solitaire said nothing at all** to tell them apart. It flashes "The game has resumed —
|
||||
Day 3, Stage 7" now, on both ways back: the setup screen's **Continue saved game**, and a bare reload
|
||||
that restores the save.
|
||||
|
||||
**The same line was wrong on the multiplayer side, in the other direction.** `noteFirstFrame` guards
|
||||
on `firstFrameSeen`, which is per page-load — so re-entering a game this browser already held a seat
|
||||
in, by reloading mid-game or picking it out of the lobby's list, announced that the game had **begun**
|
||||
to somebody who had been playing it for an hour. `beginRemote` carries whether this is a rejoin now,
|
||||
and the line reads "resumed" when it is.
|
||||
|
||||
Both halves are pinned, including that a brand-new game does *not* claim to be a resume — an
|
||||
announcement that fires either way says nothing.
|
||||
|
||||
### Three wording and layout fixes
|
||||
|
||||
- **The collision entries** on all three screens now read "The game ends immediately and results in
|
||||
@@ -249,7 +268,7 @@ Three more from Jesse reading the two screens side by side.
|
||||
cost, not a danger, and red would outrank the actual rules above it. The buttons say **Continue
|
||||
Existing Saved Game** and **Deal New Game** rather than "Continue saved game" and "Deal".
|
||||
|
||||
877 tests pass, ten of them new; one existing test asserted the opposite of the collision ruling
|
||||
878 tests pass, eleven of them new; one existing test asserted the opposite of the collision ruling
|
||||
above and says so where it was reversed.
|
||||
|
||||
---
|
||||
|
||||
Reference in New Issue
Block a user