parththakkar106andClaude Opus 5
32cd7c1077
Every test module carried the same eight-line prologue redirecting the database to a temp file. Only the first one to be imported ever took effect: `app.database` reads `AIDND_DB_PATH` at import and builds `engine` from it once, so by the time the second module ran the engine already existed. The other 34 copies created a temp file that nothing opened and nothing deleted, and leaked one per module per run. `conftest.py` now does it once, which is early enough because pytest imports conftest before any test module. It also deletes the file when the run ends. The tests still share one database, exactly as they already did: each `client` fixture calls `create_all` on setup and `drop_all` on teardown, so no test sees another test's rows. `tests/fakes.py` holds the one `ScriptedProvider`. Nine modules each had a copy, and the copies had drifted into four feature sets, so a test that needed to raise a provider error had to be written in one of the files whose copy supported that. The shared one is the superset. The two `FakeProvider` copies were the same class with a fixed reply, so they use it too. `test_chat.py` keeps its own, which implements `chat` rather than `generate` and records what it was constructed with. An autouse fixture resets the fake's class state between tests, so a stale reply list can no longer reach the next test. 435 lines out of the suite. 549 tests pass. Verified live by sabotage: breaking the shared fake fails 13 tests across four modules. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014Dix4oGV3njgWRdu7P9t6r
42 lines
1.6 KiB
Python
42 lines
1.6 KiB
Python
"""Stand-ins for the parts of the app a test must not really call.
|
|
|
|
Import these rather than writing another copy. Nine test modules each carried
|
|
their own `ScriptedProvider`, and the copies had drifted into four different
|
|
feature sets, so a test that needed to raise a provider error had to be written
|
|
in one of the files whose copy supported it.
|
|
"""
|
|
|
|
|
|
class ScriptedProvider:
|
|
"""Streams canned replies in place of `OpenAICompatibleProvider`.
|
|
|
|
Set `replies` to the texts the model returns, one per call. The last entry
|
|
repeats once the list runs out, so a test that plays more turns than it
|
|
scripted still gets text. To drive the provider-error path, put an
|
|
`Exception` in the list. It is raised rather than streamed.
|
|
|
|
State lives on the class, not on the instance, because the turn engine
|
|
constructs the provider itself and a test never sees the object. The autouse
|
|
`reset_scripted_provider` fixture in `conftest.py` clears it between tests.
|
|
|
|
`prompts` records every assembled `(system, story)` pair, which is what a
|
|
test asserts on to check what the model was shown.
|
|
"""
|
|
|
|
last_usage = None
|
|
replies: list = []
|
|
calls = 0
|
|
prompts: list = []
|
|
|
|
def __init__(self, *a, **k):
|
|
pass
|
|
|
|
async def generate(self, parts, *, temperature, max_tokens):
|
|
index = min(ScriptedProvider.calls, len(ScriptedProvider.replies) - 1)
|
|
ScriptedProvider.calls += 1
|
|
ScriptedProvider.prompts.append((parts.system, parts.story))
|
|
reply = ScriptedProvider.replies[index]
|
|
if isinstance(reply, Exception):
|
|
raise reply
|
|
yield ("text", reply)
|