JesseMarkowitzandClaude Opus 5
1ce9972760
The interface was AI-DnD's with this product's features bolted into it. The
navigation read Home · Adventures · Scenarios · Settings · AI Chat; starting a
story meant first picking a *world*, and making a world meant a JSON stat-schema
form, a story-card table and an art picker. The play screen had a Branches tab.
The input had three modes. Sixteen of the sixteen controls on a two-turn story
had no accessible name — they were single glyphs with a tooltip.
All of that was measured in a real browser before anything was changed, and the
measurements are in planning/reports/M8-IMPLEMENTATION-REPORT.md §C. Almost
nothing underneath was wrong: the play loop, the history controls, the takes,
the Save Points, the state correction and the knowledge library all worked. What
was wrong was what a reader was asked to understand in order to use them.
So the shape now is one entry point and one screen:
Campaigns -> Campaign -> Story
State · Knowledge · Context · Save Points · Settings
Everything that is not the story lives in a panel that starts closed. The
top navigation bar is hidden on the story screen entirely, because on that one
screen the story is the interface.
Play is one natural-language field. An action and a piece of quoted dialogue are
both just what the reader wrote, and B01/B02 confirmed against a real narrator
that the model reads the quotes without being told which kind of turn it is.
What survives from the old Story mode is a Story direction toggle, which is not
a fourth mode: it changes who is being spoken to, not what kind of action is
taken, and the box is visibly marked while it is on.
Branch, fork, node, merge and head appear nowhere a reader can see them. The
branch panel and the tree overlay are gone from the browser. The mechanism is
untouched — takes, divergence, retained futures and Save Points all still work,
and their endpoints are still tested. This is a decision about what a reader is
asked to understand, not a reduction of what the product can do.
The two defects worth the space:
A player action is stored with AI Dungeon's "> You " prefix. That was right when
the Do mode asked for a bare verb phrase. With one field the spec tells the
reader to write "I enter the tavern", and the result was "> You I enter the
tavern." — in the transcript, in the replayed history, and therefore in the
narration, where a small model imitates it and writes "You I thank her". M8's
own design surfaced it, so M8 fixed it: the prefix is added only when the reader
has not already written a subject. The ">" marker, which is what actually
identifies a player turn in the prompt, is unchanged in every case.
And a stale `.input-bar { display: flex }` in play.css overrode the new
composer, because that sheet is imported after the new one. The direction row
and the input row laid out side by side and the box was unusably narrow. Found
by opening the product in a browser, not by reading the CSS — which is the
argument for having done that first.
Failures now have the taxonomy the spec asked for rather than one toast: model,
generation, state, knowledge, server, each with the thing to do about it. A
failed turn leaves the reader's words in the box and says so. The classification
reads backend strings, so it is a fallback ladder rather than a lookup — an
unrecognised message still classifies, still shows the server's own words and
still offers Retry.
`Settings.model` could be empty with nothing saying so until the first turn
failed with a provider error. The header now reports Ollama in five states, and
an unconfigured or missing model offers the models actually installed on the
endpoint, from the connection test that already knew them. Nothing is chosen
automatically: an endpoint's first model may be an embedding model, which cannot
narrate at all.
Narrator prose is rendered as safe Markdown — headings, emphasis, lists,
blockquotes, code. The safety is structural rather than filtered: every node is
a React element built from parsed text, and there is no dangerouslySetInnerHTML
in the file. A sanitizer is not needed to make markup safe if markup is never
produced from input. Link schemes are checked with the URL parser rather than a
pattern, because the bypasses are all in the parsing. A remote image is a
placeholder naming the blocked address; the knowledge and context panels
deliberately do not use this renderer at all, because they exist to show a
reader exactly what is in their file.
Backend, and only what the browser could not otherwise reach:
AdventureCreate.opening a start action could only come from a Scenario, so
every campaign made in the new setup flow opened on
a blank page. Same node, same code path.
canon_rules campaign_canon has been the highest authority in a
campaign since M5, read by the prompt builder and
the state validator, and had no API at all — a
fixture had to write it with SQL.
a 401 and a 429 message the last user-facing text describing a hosted
deployment. One told the reader to check an API key
that has not existed since M2.
No schema change and no migration: proved by building a database with a server
running the M7 commit's own code and opening it with this one.
The project had no frontend tests. It has 132 now, across ten files, running
in about six seconds — the enabled state of every history control, the take
selector, the confirmations, the panels, the five model states, the failure
taxonomy, the focus trap, accessibility, and that the reserved dictation control
never touches the microphone. Writing them found a real defect: the focus trap
filtered candidates with offsetParent, which is null inside the fixed-position
ancestor the dialog has and which jsdom never computes — it would have behaved
differently in the tests from the browser.
They do not replace the real-browser runs, and both kinds of evidence are in the
report. The browser suites drive the production build served by the real backend
with a real local narrator, including a genuine process restart.
A verification pass over all of it then found three more, each by driving the
product rather than reading it:
Stepping between alternate takes did nothing. The pager asked whether a take
lived on another line by comparing `target.branch_id !== action.branch_id`, and
`ActionOut` has never carried `branch_id` — so the comparison was permanently
`number !== undefined`, always true, and every step took the branch-switch path.
For two takes of an ordinary retry, which share a line until one is written
below, that meant switching to the line already being read: the same window came
back and nothing moved. D07 is a required v1 acceptance test. The fix needed no
new field — the variants list already carries every attempt's branch and marks
the live one.
The first regression test for that passed against the broken code, because its
fixture gave the action a `branch_id` the real payload never sends. That is the
exact failure M7's review was about, so the fixture was corrected, the tests were
re-run against the reverted code and failed for the right reason, and the
fixture now carries a docstring saying why the field must never come back.
And the knowledge panel pointed readers at an "embedding model" while the
setting is called "Model for meaning-based search" — a reader sent looking for a
field that does not exist by that name.
Campaign canon was measured rather than assumed. Editing it after play is a
configuration change: every turn already played keeps the canon it was actually
given, in its own context snapshot, and the accepted story, the state document
and the state audit log are byte-identical across an edit. It is not routed
through M5's state audit, because canon is not narrative state and doing so
would create the second representation the spec forbids. What the editor does
now is say so, once a campaign has moments.
`BROWSER-UX-SPEC.md` §38 asked for a "Show Hidden Story State" toggle. There is
no hidden story state — a secret lives in a narrator-only knowledge source and
never enters the state document. The section is rewritten to require what it
actually meant: ordinary surfaces must not carry narrator-only information,
advanced inspection must withhold it by default behind an explicit warned
choice, and no second store may be invented to give a toggle something to
reveal. The protection is stricter than before, not weaker.
Closeout. An independent review returned M8 IMPLEMENTATION: PASS subject to
evidence and documentation cleanup, and this commit carries that cleanup:
The report named two frontend bundles as the artifact behind its acceptance
evidence. The saved run logs settle it. index-Ii-lARp9.js, built at 18:53:02
from this tree, is the one final frozen artifact behind all 157 browser checks;
index-C6E5Uvtu.js is superseded — it predates the D09 fix and its acceptance
suite ended 54/55 on exactly that defect. No tracked file under backend/app or
frontend/src has a modification time after the freeze, so the whole final
campaign describes one build. §P sets the two side by side.
Finding 14 — the app budgets 16,384 prompt tokens while an Ollama that sees no
VRAM enforces 4,096 — is resolved operationally, with no application change.
The OpenAI-compatible endpoint this app speaks accepts num_ctx and ignores it,
and reloads the model at its own default, so a native call cannot prime it
either. A model derived with POST /api/create carries the parameter, is honoured
through the app's own OpenAI-compatible path, and appears in /v1/models — which
is the listing the Settings model picker already reads. Measured end to end.
The procedure is in DEVELOPMENT.md; nothing in the repository depends on any
particular derived model existing. Adding provider code to work around this was
declined deliberately: it would mean either a second native request path,
against ADR 011, or a parameter the endpoint provably ignores.
The §38 rewrite is ratified as a requirement clarification aligned with the
implemented architecture, and the spec gains the clause finding 3 was really
about: withheld material must be absent from the rendered DOM, not merely
collapsed in it.
The report's §U carries the M9 handoff — what a portable campaign has to include,
whether historical context snapshots belong in the bundle, what happens to
inherited story cards, and that a restored campaign may meet a different context
window than the one that wrote it. None of it is implemented here.
Final: backend 950 passed / 14 skipped; frontend 132 passed; lint, production
build and Docker build clean; 157 browser checks across six suites, zero
failures. M8 is implemented, verified, reviewed and accepted (2026-09-06).
M9 has not been started.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017HdaXiFbscatQaLS7dJk6b
393 lines
22 KiB
Markdown
393 lines
22 KiB
Markdown
# Adventure Storyteller — Planning Package
|
||
|
||
**This file is the index. Start here.**
|
||
|
||
**Current state:** Phase 0 complete; AI-DnD forked as the production base;
|
||
milestones **M1 through M6 implemented and accepted** (M3 and M4: 2026-09-03;
|
||
M5: 2026-09-04; M6: 2026-09-06). M5 and M6 were each accepted only after an
|
||
independent review found a real defect and a corrective pass fixed it.
|
||
|
||
**M7 — First-Class Imported Knowledge Library — is complete** (2026-09-06),
|
||
after an independent review, a corrective pass and a closeout verification. Its
|
||
report keeps all three in sequence, and is now in
|
||
`archive/milestone-reports/M7-IMPLEMENTATION-REPORT.md`.
|
||
|
||
**M8 — Browser UX Completion for v1 Story Operations — is complete and
|
||
accepted** (2026-09-06), after an independent review and a closeout pass.
|
||
`reports/M8-IMPLEMENTATION-REPORT.md` is the implementer's account and now
|
||
carries the closeout: the build-evidence classification in its §P, finding 14's
|
||
operational resolution, and the acceptance record in its §V. The M8 tree is
|
||
staged and awaits the repository owner's signed commit.
|
||
|
||
**Next: M9 — Export, Backup, Recovery, and Migration Hardening.** It has not
|
||
been started.
|
||
|
||
**Package version:** see `VERSION.md`, which records what each revision changed
|
||
and why.
|
||
|
||
## Where documentation lives
|
||
|
||
```text
|
||
planning/
|
||
active specifications and implementation planning — authoritative
|
||
|
||
planning/DECISIONS/
|
||
active architectural decisions (ADRs) — authoritative
|
||
|
||
planning/reports/
|
||
the current milestone's implementation report — evidence, not instruction
|
||
|
||
planning/archive/
|
||
historical evidence and completed planning material;
|
||
not authoritative for current implementation
|
||
```
|
||
|
||
You do not need to open `planning/archive/` to do ordinary milestone work. Go
|
||
there only when an active document sends you for a specific piece of historical
|
||
evidence. If an archived document contradicts an active one, the active one is
|
||
right.
|
||
|
||
Outside `planning/`: `README.md` describes the application, `DEVELOPMENT.md` is
|
||
setup and local operation, and `PROVENANCE.md` records what came from upstream
|
||
AI-DnD and what each milestone changed.
|
||
|
||
## Which document controls
|
||
|
||
When two documents appear to conflict, the one higher in this list wins:
|
||
|
||
1. `SPECIFICATION.md` — product requirements and required behavior.
|
||
2. The detailed behavior/design documents:
|
||
`STORY-BRANCH-SEMANTICS.md`, `CONTEXT-AND-MEMORY.md`,
|
||
`IMPORTED-KNOWLEDGE-DESIGN.md`, `SECURITY-THREAT-MODEL.md`,
|
||
`MEDIA-EXTENSION-CONTRACT.md`, `BROWSER-UX-SPEC.md`, `DATA-MODEL.md`.
|
||
3. `V1-ACCEPTANCE-TESTS.md` — the observable pass/fail contract.
|
||
4. `TECHNICAL-DESIGN.md` — the selected implementation architecture.
|
||
5. The ADRs in `DECISIONS/`.
|
||
6. `BUILD-MILESTONES.md` — implementation sequence. It sequences work; it does
|
||
not override product behavior.
|
||
7. The current milestone report in `reports/`, then `planning/archive/` —
|
||
evidence and historical findings, authoritative over nothing.
|
||
|
||
Two standing qualifications:
|
||
|
||
- Candidate repositories and research reports are **not** specifications. In
|
||
particular, ai-adventure is an implementation reference for selected patterns;
|
||
its behavior does not override this package.
|
||
- Where an ADR records the architecture chosen to implement a requirement stated
|
||
elsewhere, both stand: ADR 005 states the history requirement and ADR 012
|
||
states the architecture that implements it.
|
||
|
||
## The active documents
|
||
|
||
| Document | What it is for |
|
||
| --- | --- |
|
||
| `SPECIFICATION.md` | What the product must do. The top of the authority order. |
|
||
| `TECHNICAL-DESIGN.md` | The selected architecture, including what M1-M7 built, recorded as fact. |
|
||
| `DATA-MODEL.md` | Entities, the stored head, branch disposition, and the export shape. |
|
||
| `STORY-BRANCH-SEMANTICS.md` | Undo/Redo/Retry/branch/take behavior, including the M3 ratifications. |
|
||
| `CONTEXT-AND-MEMORY.md` | Prompt assembly, summarization, branch-safe memory. |
|
||
| `IMPORTED-KNOWLEDGE-DESIGN.md` | Canon / Reference / Inspiration knowledge as a first-class subsystem. |
|
||
| `SECURITY-THREAT-MODEL.md` | The trust boundary, and the inference endpoint policy as implemented. |
|
||
| `MEDIA-EXTENSION-CONTRACT.md` | The contract future image/video/audio/TTS/STT work must fit. |
|
||
| `BROWSER-UX-SPEC.md` | The browser surface, and what is deliberately not in it. |
|
||
| `BUILD-MILESTONES.md` | M1-M11, what each delivers, what is done, and the notes each milestone leaves its successors. |
|
||
| `V1-ACCEPTANCE-TESTS.md` | The pass/fail contract v1 is measured against. |
|
||
| `TEST-CAMPAIGN-FIXTURE.md` | The standard campaign the acceptance tests are run on. |
|
||
| `VERSION.md` | Package revision history: what each closeout changed. |
|
||
| `PROJECT-SOURCES.md` | Which files to upload as ChatGPT Project Sources. |
|
||
|
||
## Reading order for a new coding agent
|
||
|
||
1. This file.
|
||
2. `SPECIFICATION.md`
|
||
3. `TECHNICAL-DESIGN.md`
|
||
4. `BUILD-MILESTONES.md` — find the milestone you are being asked to do.
|
||
5. `STORY-BRANCH-SEMANTICS.md`
|
||
6. `DATA-MODEL.md`
|
||
7. `CONTEXT-AND-MEMORY.md`
|
||
8. `IMPORTED-KNOWLEDGE-DESIGN.md`
|
||
9. `SECURITY-THREAT-MODEL.md`
|
||
10. `BROWSER-UX-SPEC.md`
|
||
11. `V1-ACCEPTANCE-TESTS.md`
|
||
12. `DECISIONS/` — all of them; they are short.
|
||
13. `reports/M8-IMPLEMENTATION-REPORT.md`, for what the most recent milestone
|
||
actually left behind — reading it as a claim to check, not a record, until
|
||
it is reviewed. Nothing in `planning/archive/` unless sent there.
|
||
|
||
## Architectural decisions
|
||
|
||
Active ADRs, all of which still constrain current or future work:
|
||
|
||
| ADR | Decision |
|
||
| --- | --- |
|
||
| `001-browser-first.md` | The UI is a browser application. |
|
||
| `002-ollama-only-v1.md` | Ollama-compatible local inference only; trusted-LAN HTTPS with a private CA is verified, never bypassed. |
|
||
| `003-authoritative-local-state.md` | The application owns authoritative state; the model does not. |
|
||
| `004-local-only-production.md` | Local-only runtime; no cloud, telemetry or runtime remote assets. |
|
||
| `005-branch-preserving-history.md` | History is preserved, not overwritten. **The requirement.** |
|
||
| `006-genre-agnostic-core.md` | The core state model is genre-agnostic. |
|
||
| `007-future-media-extension.md` | Media generation stays optional and decoupled. |
|
||
| `009-ai-dnd-production-base.md` | AI-DnD at `d72f7c1b…` is the production base. |
|
||
| `010-explicit-typed-narrative-state-events.md` | Explicit typed events / absolute assignments, not relative deltas. |
|
||
| `011-local-inference-endpoint-policy.md` | Address allowlist, deny by default, checked twice, TLS mandatory. |
|
||
| `012-active-head-non-destructive-history.md` | The stored active head. **The architecture implementing ADR 005.** |
|
||
| `013-authoritative-narrative-state-document.md` | The authoritative state document, its pipeline, and where each part lives. **The architecture implementing ADR 010.** |
|
||
|
||
`008-phase0-before-build-plan.md` was a process gate — do not begin production
|
||
work until Phase 0 closes — which Phase 0 satisfied on 2026-09-01. It is in
|
||
`archive/decisions/` and constrains nothing now. ADR numbering continues from
|
||
012; 008 is not reused.
|
||
|
||
## Milestone reports
|
||
|
||
`reports/` holds the report for the milestone most recently completed, because
|
||
that is the one the next milestone's planning has to consult:
|
||
|
||
- `reports/M8-IMPLEMENTATION-REPORT.md` — the M8 implementation, its baseline
|
||
UX measurement, and the browser evidence for every acceptance test it claims.
|
||
Written by the implementer for an independent reviewer, and completed at
|
||
closeout after that review accepted the milestone: it is a set of claims with
|
||
the measurements attached **and** the record of the acceptance. Its §U carries
|
||
the M9 handoff — the four questions the next brief has to decide.
|
||
|
||
**It stays here until M9's report replaces it.** A milestone report is useful
|
||
during the immediately following milestone; M8's is not archived merely
|
||
because M8 is accepted.
|
||
|
||
Completed earlier milestones are in `archive/milestone-reports/`, which M7's
|
||
report joined when M8's was written: a milestone report is useful during the
|
||
immediate next milestone and historical afterwards. M1-M7 are all there,
|
||
unedited.
|
||
|
||
## The decision this package rests on
|
||
|
||
Phase 0A static research and Phase 0B local validation closed on 2026-09-01 with
|
||
one decision:
|
||
|
||
> **Fork AI-DnD at upstream commit `d72f7c1bda0f34fccd84afb7a25c34eb01c901de`.**
|
||
|
||
It was chosen on measured behavior, not feature count: AI-DnD already had the
|
||
browser UI, the FastAPI service boundary, SQLite persistence, parent-linked
|
||
story history, alternate takes, branch-aware state snapshots, local Ollama
|
||
operation, branch-scoped memory, prompt inspection, streaming, export/import and
|
||
a substantial test suite. The composition of ideas selected around it:
|
||
|
||
```text
|
||
AI-DnD production base
|
||
+ ai-adventure state/event/commit/checkpoint/privacy patterns
|
||
+ Open Dungeon story-reading and future-media UX patterns
|
||
+ Chronicler memory-authority concepts
|
||
+ Interactive Fiction Framework canon/validation concepts
|
||
+ Gamentic provider-neutral media concepts
|
||
```
|
||
|
||
This is **not** a repository merge. AI-DnD is the ownership center; the others
|
||
are implementation references only.
|
||
|
||
Phase 0B also corrected several Phase 0A assumptions, and those corrections are
|
||
now built into the active documents rather than needing to be read from the
|
||
research: shipped Undo was destructive with no Redo (ADR 012 replaced it);
|
||
relative-delta world state can be semantically wrong while syntactically valid
|
||
(ADR 010); `tiktoken` and Google Fonts broke offline operation (fixed in M1);
|
||
export had to carry the head position (M3); Story Cards were not a sufficient
|
||
imported-knowledge store (`IMPORTED-KNOWLEDGE-DESIGN.md`).
|
||
|
||
The evidence is in `archive/phase0/`, and `archive/phase0/PHASE-0B-RECOMMENDATION.md`
|
||
is the strongest single document there. It is research evidence, not a
|
||
specification, and it was not rewritten to match later conclusions.
|
||
|
||
## Foundational Decisions
|
||
|
||
The following are settled for v1:
|
||
|
||
- browser-first UI,
|
||
- local-only runtime across user-controlled local infrastructure,
|
||
- Ollama inference with same-host loopback as default and explicitly configured trusted-LAN inference supported,
|
||
- single-user deployment,
|
||
- AI-DnD production base at the pinned Phase 0B commit,
|
||
- application-owned authoritative state,
|
||
- complete retained transcript/history,
|
||
- simple user-facing Undo/Redo/Retry/Save Point semantics,
|
||
- non-destructive head-cursor history internally,
|
||
- new write after moving backward creates a new continuation while retaining the old future,
|
||
- abandoned history is retained and marked disposable; **no automatic cleanup is required in v1**,
|
||
- named checkpoints remain until explicitly deleted,
|
||
- genre-agnostic core state,
|
||
- explicit typed narrative-state events/absolute assignments rather than ambiguous relative deltas,
|
||
- hybrid state model: validated events plus state snapshots/cache,
|
||
- branch/lineage-safe summaries and memories,
|
||
- imported knowledge is a separate first-class subsystem rather than an extension of AI-DnD Story Cards,
|
||
- knowledge classes: Canon / Reference / Inspiration,
|
||
- local lexical retrieval plus local semantic retrieval where practical,
|
||
- prompt/context provenance and inspection,
|
||
- export/import must preserve active branch **and active head position**, including an undone position,
|
||
- no cloud/Internet inference, telemetry, automatic web retrieval, remote runtime assets, shell/MCP/general plugin execution,
|
||
- LAN inference is distinct from LAN exposure of the storyteller UI/API; the latter is not required for v1,
|
||
- future local image/video/audio/TTS/STT support remains optional and decoupled from the story engine.
|
||
|
||
|
||
## Still open, and deliberately so
|
||
|
||
These do not block the architecture and are not v1 requirements:
|
||
|
||
- comparative recommendation of narrator/state models for real users,
|
||
- multi-hour/100-turn long-run behavior,
|
||
- detailed concurrency behavior beyond the single-user turn lock,
|
||
- actual future image/video/TTS/STT provider integration,
|
||
- abandoned-history cleanup UI/policy (not required in v1).
|
||
|
||
|
||
## Where the work stands
|
||
|
||
```text
|
||
Phase 0 research and spikes COMPLETE
|
||
Architecture/fork decision COMPLETE
|
||
Planning package approved COMPLETE
|
||
|
|
||
v
|
||
Milestone M1 COMPLETE (2026-09-02)
|
||
fork + offline baseline archive/milestone-reports/M1-*.md
|
||
|
|
||
v
|
||
Milestone M2 COMPLETE (2026-09-02)
|
||
local-only surface + endpoint archive/milestone-reports/M2-*.md
|
||
policy
|
||
|
|
||
v
|
||
Milestone M3 COMPLETE (2026-09-03)
|
||
non-destructive undo/redo, archive/milestone-reports/M3-*.md
|
||
active-head export and ADR 012
|
||
|
|
||
v
|
||
Milestone M4 COMPLETE (2026-09-03)
|
||
named Save Points archive/milestone-reports/M4-*.md
|
||
| browser verification: PASS (M3 + M4)
|
||
v
|
||
Milestone M5 COMPLETE (2026-09-04)
|
||
authoritative narrative state archive/milestone-reports/M5-*.md
|
||
| and ADR 013
|
||
v
|
||
Milestone M6 COMPLETE (2026-09-06)
|
||
branch-safe context, summaries archive/milestone-reports/M6-*.md
|
||
and long-term story memory
|
||
|
|
||
v
|
||
Milestone M7 COMPLETE (2026-09-06)
|
||
first-class imported knowledge archive/milestone-reports/M7-*.md
|
||
library review + corrective + closeout, in sequence
|
||
|
|
||
v
|
||
Milestone M8 COMPLETE / ACCEPTED (2026-09-06)
|
||
browser UX completion for v1 reports/M8-IMPLEMENTATION-REPORT.md
|
||
story operations review + closeout, in sequence
|
||
|
|
||
v
|
||
Milestone M9 NEXT — not started
|
||
export, backup, recovery, see BUILD-MILESTONES.md
|
||
migration hardening
|
||
|
|
||
v
|
||
M10-M11, one at a time see BUILD-MILESTONES.md
|
||
```
|
||
|
||
## Stop Rule
|
||
|
||
**One milestone at a time. Do not begin a milestone before its brief exists.**
|
||
|
||
**No M9 brief has been prepared.** Writing one is the current action, informed
|
||
by the M8 report and by the debt `BUILD-MILESTONES.md` records against M8 — in
|
||
particular that the campaign bundle still carries no context snapshots, so an
|
||
imported campaign has no historical prompt provenance; that story cards survive
|
||
in the backend and the bundle with no browser surface, and M9 should decide
|
||
deliberately whether the bundle keeps carrying them; and that a deployment whose
|
||
Ollama enforces a small context window truncates an imported long campaign
|
||
immediately unless the `DEVELOPMENT.md` procedure or a matching
|
||
`context_token_budget` is applied.
|
||
|
||
**M8's own carried debt** is recorded under M8 in `BUILD-MILESTONES.md`: story
|
||
cards have no browser editor, the RPG world state is read-only, copy is
|
||
per-message only, there is no discarded-history recovery screen, and the tablet
|
||
layout is usable but untuned. Each names the milestone that owns it; none is an
|
||
open M8 condition.
|
||
|
||
The M6 retrieval debt this milestone was warned about is partly addressed and
|
||
partly still open. Imported material does **not** compete with story memory for
|
||
one budget — M7 gave it a separate bounded budget of its own — and ranking for
|
||
imported knowledge is now relevance × class rather than similarity plus a pin.
|
||
Story-memory ranking is unchanged, and cross-layer duplication
|
||
(`CONTEXT-AND-MEMORY.md` §22) is still open: the same fact can still appear in
|
||
state, memory, history and now an imported passage at once.
|
||
|
||
**No conditions remain open on M1-M6.** The browser smoke condition that M3 and
|
||
M4 both carried was satisfied at M4 closeout: a real Firefox exercised the
|
||
rendered DOM for both milestones' controls, 44/44 checks passing. The M3 report's
|
||
§M.2 and the M4 report's §M record the condition as it stood; the M4 report's §W
|
||
records it closed.
|
||
|
||
## What each milestone closeout corrected
|
||
|
||
These tables are the audit trail: what implementation evidence forced back into
|
||
the planning package, milestone by milestone. `VERSION.md` narrates the same
|
||
changes.
|
||
|
||
### Post-M3 corrections applied (2026-09-03)
|
||
|
||
M3's review recommended planning changes and, following the M2 pattern, reported
|
||
rather than applied them. All are now applied, together with the closeout work
|
||
the milestone itself required:
|
||
|
||
| Document | Correction |
|
||
| --- | --- |
|
||
| `DECISIONS/012-active-head-non-destructive-history.md` | **New ADR.** The architecture selected to implement ADR 005: head stored not derived, one capped read path, one movement mechanism, state from the node, divergence on first write below the head, Redo decided by the lineage, advisory disposition metadata, and the head as an exported decision. |
|
||
| `STORY-BRANCH-SEMANTICS.md` §5 | Undo crosses fork points and continues to the campaign opening. The old refusal was a consequence of destructive deletion, not a product decision. |
|
||
| `STORY-BRANCH-SEMANTICS.md` §10 | Switching which take is live is refused while a later story is off screen, with the two resolutions the user has. |
|
||
| `STORY-BRANCH-SEMANTICS.md` §14A | **New.** In-place editing before §14-15 exist: refuse when story descends from the turn and is not on screen. States explicitly that the full narrator-edit requirement stands and is completed in M5. |
|
||
| `TECHNICAL-DESIGN.md` §8.7, §9.1 | **New.** The implemented active-head model and bundle behaviour, recorded as fact. |
|
||
| `TECHNICAL-DESIGN.md` §10.4 | Constraint from M3: the snapshot half of the hybrid state model is a requirement, or head movement becomes proportional to campaign length. |
|
||
| `DATA-MODEL.md` §4, §5, §29 | The head as campaign-stored rather than derived; the branch disposition as implemented and deliberately advisory; the export as carrying a chosen position. |
|
||
| `BUILD-MILESTONES.md` M3 | Marked COMPLETE, with inherited capabilities, the open browser condition, and carried debt. |
|
||
| `BUILD-MILESTONES.md` M4 | Note: a Save Point is a durable pointer; restore by reusing M3's head movement rather than building a second restore path. |
|
||
| `BUILD-MILESTONES.md` M5 | Note: keep state efficiently recoverable at a position; move the test instrumentation rather than the assertions; complete the narrator edit. |
|
||
| `V1-ACCEPTANCE-TESTS.md` D03, D10, I07, L01 | D03's result recorded as a full pass; **D10's milestone ownership stated without weakening any pass condition**; I07's pre-M3 bundle clause added; the apparent L01/A05 conflict resolved. |
|
||
| `README.md` | Corrected to describe the current local-only single-user application. The scripting, accounts, analytics, hosted-demo, cloud-provider, Postgres and Render material described subsystems M2 removed. |
|
||
|
||
`SPECIFICATION.md` and `SECURITY-THREAT-MODEL.md` were deliberately **not**
|
||
changed. M3 altered no product requirement and touched no path in the threat
|
||
model.
|
||
|
||
### Post-M2 corrections applied (2026-09-03)
|
||
|
||
M2's review recommended six planning changes and reported rather than applied
|
||
them. All six are now applied, plus three additions drawn from the same evidence:
|
||
|
||
| Document | Correction |
|
||
| --- | --- |
|
||
| `SECURITY-THREAT-MODEL.md` | New §10A records the inference endpoint policy **as implemented** — address allowlist, enforced on save and before every request, TLS never traded against it — with both residual limits stated. §71A item 5 marked resolved; §77 notes the required defaults are now met. |
|
||
| `TECHNICAL-DESIGN.md` §5.1 | Items 3 and 4 marked done; all five hardening items are now resolved. |
|
||
| `TECHNICAL-DESIGN.md` §5.2 | New: the M1/M2 production architecture recorded as fact — SQLite, Ollama-only, loopback storyteller, trusted-LAN inference accepted, public endpoints refused. |
|
||
| `TECHNICAL-DESIGN.md` §18.1 | New wiring rule from the M2 regressions: test a real consumer path when removing a setting, and prove a new setting reaches its component. |
|
||
| `DECISIONS/011-local-inference-endpoint-policy.md` | **New ADR.** Address-based allowlist over hostname matching, deny by default, checked twice, mandatory TLS — with the `ipaddress`-classification finding as the reason the CIDRs are spelled out. |
|
||
| `BUILD-MILESTONES.md` M2 | Marked COMPLETE with the capabilities it delivered and the debt it carried forward. |
|
||
| `BUILD-MILESTONES.md` M5 | Note: eight rollback tests now use the world-state engine as *instrumentation*, not as endorsement; move the instrumentation when M5 replaces the protocol, and rework rather than delete those tests. |
|
||
| `BUILD-MILESTONES.md` M6 | Note: background memory failure must be observable, at least one real provider-construction path must be tested, and derived-memory failure must not corrupt accepted story state. |
|
||
| `V1-ACCEPTANCE-TESTS.md` H10 | Strengthened: a wildcard origin must be rejected at startup, and an unknown `/api/...` path must 404 rather than returning the SPA with HTTP 200. |
|
||
| `V1-ACCEPTANCE-TESTS.md` H12 | **New.** Inference endpoint enforcement, including the defence-in-depth case: a public endpoint written into the database behind the settings API must still be refused at request time. |
|
||
|
||
`SPECIFICATION.md` was deliberately **not** changed. M2 altered no product
|
||
requirement; it removed capability the specification never asked for.
|
||
|
||
### Post-M1 corrections applied (2026-09-02)
|
||
|
||
Implementation evidence contradicted or under-specified six places in this
|
||
package, and a seventh was added on review. All seven are now corrected:
|
||
|
||
| Document | Correction |
|
||
| --- | --- |
|
||
| `DECISIONS/002-ollama-only-v1.md` | New section: a trusted-LAN Ollama may be HTTPS with a private CA; verify against the OS trust store; full certificate and hostname checking; no bypass option. |
|
||
| `DECISIONS/004-local-only-production.md` | New *Testing Consequence*: offline tests need a fresh cache and no route out. Vendored runtime artifacts should be integrity-verifiable. |
|
||
| `V1-ACCEPTANCE-TESTS.md` A05 | Pass conditions reworded around *accepted* history; explicit note that the user's submitted text is deliberately retained. |
|
||
| `V1-ACCEPTANCE-TESTS.md` A06 | Now requires a real second machine and an HTTPS endpoint with a locally issued certificate; a plain-HTTP LAN test is no longer sufficient evidence. |
|
||
| `V1-ACCEPTANCE-TESTS.md` §3 | Record CPU/GPU/RAM: cold model load on a CPU-only host exceeded the inherited 120 s timeout. |
|
||
| `BUILD-MILESTONES.md` | M1 marked COMPLETE with the capabilities it delivered; M2's endpoint-policy line reframed from inventing trusted-LAN support to narrowing it. |
|
||
| `TECHNICAL-DESIGN.md` §5 | Runtime boundary restated: the storyteller is loopback-only, inference may be same-host *or* trusted-LAN, and the two are independent. Adds the TLS/private-CA rule. |
|