JesseMarkowitzandClaude Opus 5
1ce9972760
The interface was AI-DnD's with this product's features bolted into it. The
navigation read Home · Adventures · Scenarios · Settings · AI Chat; starting a
story meant first picking a *world*, and making a world meant a JSON stat-schema
form, a story-card table and an art picker. The play screen had a Branches tab.
The input had three modes. Sixteen of the sixteen controls on a two-turn story
had no accessible name — they were single glyphs with a tooltip.
All of that was measured in a real browser before anything was changed, and the
measurements are in planning/reports/M8-IMPLEMENTATION-REPORT.md §C. Almost
nothing underneath was wrong: the play loop, the history controls, the takes,
the Save Points, the state correction and the knowledge library all worked. What
was wrong was what a reader was asked to understand in order to use them.
So the shape now is one entry point and one screen:
Campaigns -> Campaign -> Story
State · Knowledge · Context · Save Points · Settings
Everything that is not the story lives in a panel that starts closed. The
top navigation bar is hidden on the story screen entirely, because on that one
screen the story is the interface.
Play is one natural-language field. An action and a piece of quoted dialogue are
both just what the reader wrote, and B01/B02 confirmed against a real narrator
that the model reads the quotes without being told which kind of turn it is.
What survives from the old Story mode is a Story direction toggle, which is not
a fourth mode: it changes who is being spoken to, not what kind of action is
taken, and the box is visibly marked while it is on.
Branch, fork, node, merge and head appear nowhere a reader can see them. The
branch panel and the tree overlay are gone from the browser. The mechanism is
untouched — takes, divergence, retained futures and Save Points all still work,
and their endpoints are still tested. This is a decision about what a reader is
asked to understand, not a reduction of what the product can do.
The two defects worth the space:
A player action is stored with AI Dungeon's "> You " prefix. That was right when
the Do mode asked for a bare verb phrase. With one field the spec tells the
reader to write "I enter the tavern", and the result was "> You I enter the
tavern." — in the transcript, in the replayed history, and therefore in the
narration, where a small model imitates it and writes "You I thank her". M8's
own design surfaced it, so M8 fixed it: the prefix is added only when the reader
has not already written a subject. The ">" marker, which is what actually
identifies a player turn in the prompt, is unchanged in every case.
And a stale `.input-bar { display: flex }` in play.css overrode the new
composer, because that sheet is imported after the new one. The direction row
and the input row laid out side by side and the box was unusably narrow. Found
by opening the product in a browser, not by reading the CSS — which is the
argument for having done that first.
Failures now have the taxonomy the spec asked for rather than one toast: model,
generation, state, knowledge, server, each with the thing to do about it. A
failed turn leaves the reader's words in the box and says so. The classification
reads backend strings, so it is a fallback ladder rather than a lookup — an
unrecognised message still classifies, still shows the server's own words and
still offers Retry.
`Settings.model` could be empty with nothing saying so until the first turn
failed with a provider error. The header now reports Ollama in five states, and
an unconfigured or missing model offers the models actually installed on the
endpoint, from the connection test that already knew them. Nothing is chosen
automatically: an endpoint's first model may be an embedding model, which cannot
narrate at all.
Narrator prose is rendered as safe Markdown — headings, emphasis, lists,
blockquotes, code. The safety is structural rather than filtered: every node is
a React element built from parsed text, and there is no dangerouslySetInnerHTML
in the file. A sanitizer is not needed to make markup safe if markup is never
produced from input. Link schemes are checked with the URL parser rather than a
pattern, because the bypasses are all in the parsing. A remote image is a
placeholder naming the blocked address; the knowledge and context panels
deliberately do not use this renderer at all, because they exist to show a
reader exactly what is in their file.
Backend, and only what the browser could not otherwise reach:
AdventureCreate.opening a start action could only come from a Scenario, so
every campaign made in the new setup flow opened on
a blank page. Same node, same code path.
canon_rules campaign_canon has been the highest authority in a
campaign since M5, read by the prompt builder and
the state validator, and had no API at all — a
fixture had to write it with SQL.
a 401 and a 429 message the last user-facing text describing a hosted
deployment. One told the reader to check an API key
that has not existed since M2.
No schema change and no migration: proved by building a database with a server
running the M7 commit's own code and opening it with this one.
The project had no frontend tests. It has 132 now, across ten files, running
in about six seconds — the enabled state of every history control, the take
selector, the confirmations, the panels, the five model states, the failure
taxonomy, the focus trap, accessibility, and that the reserved dictation control
never touches the microphone. Writing them found a real defect: the focus trap
filtered candidates with offsetParent, which is null inside the fixed-position
ancestor the dialog has and which jsdom never computes — it would have behaved
differently in the tests from the browser.
They do not replace the real-browser runs, and both kinds of evidence are in the
report. The browser suites drive the production build served by the real backend
with a real local narrator, including a genuine process restart.
A verification pass over all of it then found three more, each by driving the
product rather than reading it:
Stepping between alternate takes did nothing. The pager asked whether a take
lived on another line by comparing `target.branch_id !== action.branch_id`, and
`ActionOut` has never carried `branch_id` — so the comparison was permanently
`number !== undefined`, always true, and every step took the branch-switch path.
For two takes of an ordinary retry, which share a line until one is written
below, that meant switching to the line already being read: the same window came
back and nothing moved. D07 is a required v1 acceptance test. The fix needed no
new field — the variants list already carries every attempt's branch and marks
the live one.
The first regression test for that passed against the broken code, because its
fixture gave the action a `branch_id` the real payload never sends. That is the
exact failure M7's review was about, so the fixture was corrected, the tests were
re-run against the reverted code and failed for the right reason, and the
fixture now carries a docstring saying why the field must never come back.
And the knowledge panel pointed readers at an "embedding model" while the
setting is called "Model for meaning-based search" — a reader sent looking for a
field that does not exist by that name.
Campaign canon was measured rather than assumed. Editing it after play is a
configuration change: every turn already played keeps the canon it was actually
given, in its own context snapshot, and the accepted story, the state document
and the state audit log are byte-identical across an edit. It is not routed
through M5's state audit, because canon is not narrative state and doing so
would create the second representation the spec forbids. What the editor does
now is say so, once a campaign has moments.
`BROWSER-UX-SPEC.md` §38 asked for a "Show Hidden Story State" toggle. There is
no hidden story state — a secret lives in a narrator-only knowledge source and
never enters the state document. The section is rewritten to require what it
actually meant: ordinary surfaces must not carry narrator-only information,
advanced inspection must withhold it by default behind an explicit warned
choice, and no second store may be invented to give a toggle something to
reveal. The protection is stricter than before, not weaker.
Closeout. An independent review returned M8 IMPLEMENTATION: PASS subject to
evidence and documentation cleanup, and this commit carries that cleanup:
The report named two frontend bundles as the artifact behind its acceptance
evidence. The saved run logs settle it. index-Ii-lARp9.js, built at 18:53:02
from this tree, is the one final frozen artifact behind all 157 browser checks;
index-C6E5Uvtu.js is superseded — it predates the D09 fix and its acceptance
suite ended 54/55 on exactly that defect. No tracked file under backend/app or
frontend/src has a modification time after the freeze, so the whole final
campaign describes one build. §P sets the two side by side.
Finding 14 — the app budgets 16,384 prompt tokens while an Ollama that sees no
VRAM enforces 4,096 — is resolved operationally, with no application change.
The OpenAI-compatible endpoint this app speaks accepts num_ctx and ignores it,
and reloads the model at its own default, so a native call cannot prime it
either. A model derived with POST /api/create carries the parameter, is honoured
through the app's own OpenAI-compatible path, and appears in /v1/models — which
is the listing the Settings model picker already reads. Measured end to end.
The procedure is in DEVELOPMENT.md; nothing in the repository depends on any
particular derived model existing. Adding provider code to work around this was
declined deliberately: it would mean either a second native request path,
against ADR 011, or a parameter the endpoint provably ignores.
The §38 rewrite is ratified as a requirement clarification aligned with the
implemented architecture, and the spec gains the clause finding 3 was really
about: withheld material must be absent from the rendered DOM, not merely
collapsed in it.
The report's §U carries the M9 handoff — what a portable campaign has to include,
whether historical context snapshots belong in the bundle, what happens to
inherited story cards, and that a restored campaign may meet a different context
window than the one that wrote it. None of it is implemented here.
Final: backend 950 passed / 14 skipped; frontend 132 passed; lint, production
build and Docker build clean; 157 browser checks across six suites, zero
failures. M8 is implemented, verified, reviewed and accepted (2026-09-06).
M9 has not been started.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017HdaXiFbscatQaLS7dJk6b
595 lines
34 KiB
Markdown
595 lines
34 KiB
Markdown
# Planning Package Version
|
||
|
||
- **Package:** Adventure Storyteller Planning Package v3.3
|
||
- **Revision date:** 2026-09-06
|
||
- **Status:** Phase 0 complete; architecture selected; **Milestones M1-M8 implemented and accepted** (M8 closed out 2026-09-06). M9 is next and has not been started.
|
||
|
||
## v3.3 — M8 Closeout (2026-09-06)
|
||
|
||
M8 is **complete and accepted**. The independent review returned
|
||
`M8 IMPLEMENTATION: PASS` subject to evidence and documentation cleanup; this
|
||
revision is that cleanup. No product requirement changed and no application code
|
||
changed in it.
|
||
|
||
**What M8 leaves the package with**
|
||
|
||
- **The browser is now the intended v1 storyteller surface**, not an adapted
|
||
AI-DnD one. One entry point, one story screen, one natural-language field;
|
||
State, Knowledge, Context, Save Points and campaign Settings one layer deeper
|
||
behind panels that start closed. Branch, fork, node, head and depth appear
|
||
nowhere a reader can see them — audited in source and in the live DOM, 0 hits.
|
||
- **Automated frontend testing exists for the first time** — 132 tests across 10
|
||
files. The project had none before M8.
|
||
- **Hidden narrator information is withheld at the surface that can actually
|
||
expose it** — advanced context inspection — rather than through a fictitious
|
||
separate hidden-state subsystem. Withheld text is absent from the DOM, not
|
||
collapsed inside it.
|
||
- **Final acceptance evidence:** 950 backend passed / 14 skipped / 0 failed; 132
|
||
frontend passed; lint, production build and Docker build clean; **157 browser
|
||
checks across six suites, zero failures**, on one frozen build; no schema
|
||
change, proved against an M7-built database.
|
||
- **M9 — Export, Backup, Recovery, and Migration Hardening — is next.** Its four
|
||
handoff questions are in the M8 report's §U.
|
||
|
||
**What the closeout settled**
|
||
|
||
- **The build-evidence contradiction.** The M8 report named two different
|
||
frontend bundles as the artifact behind its acceptance evidence. The saved run
|
||
logs settle it: `index-Ii-lARp9.js`, built 18:53:02 from the staged tree, is
|
||
the one **final frozen** artifact behind all 157 browser checks.
|
||
`index-C6E5Uvtu.js` is **superseded** — it predates finding 7's fix and its
|
||
acceptance suite ended 54/55 on exactly that defect. The report's §P now sets
|
||
the two side by side, and §B, §Q and §S agree with it.
|
||
- **Finding 14 — resolved, operationally, with no application change.** Ollama's
|
||
OpenAI-compatible endpoint ignores `num_ctx` and reloads the model at its own
|
||
default, so the window cannot be set per request from where this application
|
||
stands. A **derived model** created over `/api/create` carries the parameter,
|
||
is honoured through the application's own OpenAI-compatible path, and appears
|
||
in `/v1/models` — so the existing Settings model picker finds it with no code
|
||
change. Measured end to end. It is now an operational note in
|
||
`DEVELOPMENT.md`, not an unresolved M11 blocker.
|
||
- **`BROWSER-UX-SPEC.md` §38 — ratified.** The change from *"Show Hidden Story
|
||
State"* to the requirement on **hidden narrator information / spoilers** is
|
||
accepted as a **requirement clarification aligned with the implemented
|
||
architecture**, not a weakening: ordinary Story and State surfaces expose no
|
||
narrator-only information; the advanced Context and Knowledge surfaces that
|
||
could withhold it by default; revealing it takes an explicit, warned action;
|
||
withheld material is **absent from the DOM**, not merely collapsed; and no
|
||
duplicate hidden-state subsystem is required to satisfy obsolete UI wording.
|
||
Verified by the sentinel suite, 21/21.
|
||
|
||
**Documents changed**
|
||
|
||
- `reports/M8-IMPLEMENTATION-REPORT.md` — §A, §B, §D, §P, §Q, §S (findings 13
|
||
and 14), §T, §U and §V. §U gains the **M9 handoff**: complete campaign
|
||
portability, historical prompt/context provenance in the bundle, legacy story
|
||
cards, and context-window portability. Verification figures unchanged.
|
||
- `BROWSER-UX-SPEC.md` §38 — one requirement added: withheld material must be
|
||
**absent from the rendered DOM**, not merely visually collapsed. A closed
|
||
`<details>` is still findable by browser search and by the accessibility tree,
|
||
which is how finding 3 leaked.
|
||
- `PROJECT-SOURCES.md`, `V1-ACCEPTANCE-TESTS.md` — three pointers still aimed at
|
||
`reports/M7-IMPLEMENTATION-REPORT.md`, which M8's rotation moved to the
|
||
archive.
|
||
- `BUILD-MILESTONES.md` — M8 marked **COMPLETE / ACCEPTED**, M9 marked next and
|
||
not started, finding 14's carried-forward entry reworded as resolved.
|
||
- `README.md` (planning) — M8 complete and accepted; next is M9.
|
||
- `VERSION.md` — this entry.
|
||
- `DEVELOPMENT.md` — the derived-model procedure (carried from the finding-14
|
||
investigation).
|
||
|
||
**Status discipline.** M8 is implemented, verified, reviewed and accepted. It is
|
||
**not committed**: the tree is staged for the repository owner's signature. M9
|
||
has not been started.
|
||
|
||
---
|
||
|
||
## v3.2 — M8 Final Verification Pass (2026-09-06)
|
||
|
||
The corrective, verification and reporting pass over M8. At the time of this
|
||
revision M8 was **implemented and verified, not accepted**; v3.3 records the
|
||
review outcome and the acceptance.
|
||
|
||
**Documents changed in this pass**
|
||
|
||
- `BROWSER-UX-SPEC.md` §38 — **requirement clarification.** Rewritten from
|
||
"Hidden Narrator State" with a `Show Hidden Story State` toggle to
|
||
"Hidden Narrator Information / Spoilers". The protection required is
|
||
unchanged and, if anything, stated more strictly; what changed is that it
|
||
no longer names a state subsystem that does not exist, and it now forbids
|
||
inventing one. §100's checklist entry follows it.
|
||
- `TECHNICAL-DESIGN.md` — **implementation fact.** Campaign canon is
|
||
configuration; its provenance is the per-turn context snapshot, measured
|
||
rather than assumed.
|
||
- `V1-ACCEPTANCE-TESTS.md`, `BUILD-MILESTONES.md`, `README.md`,
|
||
`DEVELOPMENT.md` — implementation facts and final counts.
|
||
|
||
**No product requirement was weakened.** The §38 change is the only one that
|
||
touches a requirement's wording, and it tightens it.
|
||
|
||
---
|
||
|
||
## v3.1 — M8 Implementation (2026-09-06)
|
||
|
||
M8 turned the adapted AI-DnD interface into the interactive-story workspace
|
||
`BROWSER-UX-SPEC.md` describes. Not yet accepted — the report is written for an
|
||
independent reviewer.
|
||
|
||
**Documents changed**
|
||
|
||
- `BROWSER-UX-SPEC.md` — four "As implemented in M8" notes (§12 one input, §31
|
||
the state panel and why there is no hidden-state toggle there, §55 the context
|
||
inspector's default view, §57 click-through and the narrator-only guard). No
|
||
requirement was altered.
|
||
- `TECHNICAL-DESIGN.md` — new §13.4, recording that the browser stayed a
|
||
presentation layer, the failure taxonomy, and why markup is never produced
|
||
from input.
|
||
- `BUILD-MILESTONES.md` — M8's outcome and the debt it carries forward.
|
||
- `V1-ACCEPTANCE-TESTS.md` — B01-B04 and D01-D14 recorded as browser evidence.
|
||
- `README.md`, `DEVELOPMENT.md` — one input rather than four modes, the context
|
||
inspector, the component test suite, and the removal of "no frontend tests"
|
||
from the inherited-debt list.
|
||
|
||
**What M8 established that the plan did not already say**
|
||
|
||
- The narrative state has **no hidden dimension**, so §38's `Show Hidden Story
|
||
State` has nothing to reveal there. A campaign's secrets live in narrator-only
|
||
knowledge sources, and the only ordinary screen that can surface one is the
|
||
context inspector — which is where the guard was built.
|
||
- `campaign_canon` had no API. It is the highest authority in a campaign, read
|
||
by both the prompt builder and the state validator since M5, and until M8 a
|
||
fixture had to write it with SQL.
|
||
- AI Dungeon's `> You {text}` player-input convention is incompatible with one
|
||
natural-language field: it produced `> You I enter the tavern.`, which a small
|
||
model then imitates. Corrected for first-person input.
|
||
|
||
---
|
||
|
||
## v3.0 — M7 Closeout (2026-09-06)
|
||
|
||
M7 is complete. Two items the corrective pass had left open are resolved.
|
||
|
||
**The embedding-model calibration boundary.** `SEMANTIC_FLOOR = 0.58` was
|
||
measured against `nomic-embed-text`, and the corrective pass documented only the
|
||
safe half of that: a model scoring everything lower degrades to lexical-only. A
|
||
model scoring unrelated material *higher* would have recreated M7-F1 on a build
|
||
whose tests all pass. Semantic admission is now **per model**: an uncalibrated
|
||
model does not inherit the threshold, semantic retrieval is skipped for it with
|
||
the reason reported, and the library degrades to lexical-only. Recorded in
|
||
`TECHNICAL-DESIGN.md` §13.3 and `IMPORTED-KNOWLEDGE-DESIGN.md` §76.
|
||
|
||
**The ambiguous `export/import 53/54`.** The 54th case was a false positive in
|
||
the independent review's own harness — its "no filesystem path" assertion was a
|
||
substring test that fired on `text/markdown`, a MIME type. Replaced with three
|
||
precise checks; the suite is **56/56** and no product behaviour was involved.
|
||
|
||
**What closeout changed in the active documents:**
|
||
|
||
- `TECHNICAL-DESIGN.md` §13.3 — **new.** A similarity threshold is a property of
|
||
the model, the two ways a different model breaks it are not symmetric, and the
|
||
product refuses to apply a threshold to a model it has not measured.
|
||
- `IMPORTED-KNOWLEDGE-DESIGN.md` §76 — the same, in the design's own terms:
|
||
§25's local-Ollama embedding stands; what is added is that a *threshold* must
|
||
be measured before it is trusted.
|
||
- `BUILD-MILESTONES.md` M7 — marked COMPLETE, with the capabilities later
|
||
milestones inherit and the debt carried forward, including that calibrating
|
||
further embedding models is a measurement rather than a guess.
|
||
- `V1-ACCEPTANCE-TESTS.md` — the M7 results promoted from implementation-pass
|
||
evidence to reviewed results.
|
||
|
||
## v2.9 — M7 Independent Review and Corrective Pass (2026-09-06)
|
||
|
||
The review returned *PASS WITH CORRECTIVE WORK REQUIRED*. It closed the five
|
||
acceptance conditions the implementation had flagged as unmeasured — C05, G06,
|
||
G07, G10 and hidden Canon, all exercised against a real narrator and all
|
||
passing — and found two blocking defects, both now corrected.
|
||
|
||
**M7-F1 — imported knowledge was injected regardless of relevance.** Relevance
|
||
was decided by a floor expressed as a share of the best candidate, which the
|
||
best clears by construction. A query about tide tables and container tonnage
|
||
retrieved all five sources of a fantasy campaign, narrator-only hidden Canon
|
||
among them. Corrected by separating relevance **admission** from **ranking**.
|
||
|
||
**M7-F2 — the retrieval suite could not detect it.** Its stub scored unrelated
|
||
text an order of magnitude lower than the real model, so the broken gate passed.
|
||
Corrected with a stub that has the real model's similarity floor, plus a test
|
||
that fails if the floor is removed and one that shows the superseded rule still
|
||
being fooled. The new suite fails 13/18 against the pre-corrective code.
|
||
|
||
**What the corrective pass forced into the active documents:**
|
||
|
||
- `TECHNICAL-DESIGN.md` §13.2 — **new.** Relevance admission is a separate stage
|
||
from ranking, and the general rule behind it: a relevance decision must rest on
|
||
a signal meaningful on its own, because normalization answers "which of these
|
||
is best" and can never answer "is any of these any good". A pipeline that ranks
|
||
first and cuts second has no way to return nothing.
|
||
- `TECHNICAL-DESIGN.md` §13.1 — the pipeline diagram gains the admission stage.
|
||
- `IMPORTED-KNOWLEDGE-DESIGN.md` §76 — retrieval corrected: admission before
|
||
authority, and the plain statement that **retrieval may return nothing**,
|
||
which is what §30 means when every source is irrelevant.
|
||
- `BUILD-MILESTONES.md` M7 § Status — both findings, their corrections, and the
|
||
model-specific calibration recorded as carried debt.
|
||
|
||
Three non-blocking findings were folded in: a relevance constant that could
|
||
never fire was removed rather than re-tuned; the acceptance tests moved to the
|
||
standard `TEST-CAMPAIGN-FIXTURE.md` §12 files so G07's trap is finally
|
||
exercised; and Unicode format characters are stripped from displayed filenames.
|
||
A pre-existing M5 narrator-protocol issue was recorded and deliberately left
|
||
with M5.
|
||
|
||
## v2.8 — M7 Implementation Pass (2026-09-06)
|
||
|
||
**Not a closeout.** M7 is implemented, not accepted, and this revision records
|
||
what the implementation pass built and measured so that an independent review
|
||
has something to verify against. No milestone report was written: the
|
||
convention this package follows puts the report in `reports/` and has the
|
||
*reviewer* write it, treating the build summary as claims to check.
|
||
|
||
**M7 — First-Class Imported Knowledge Library.** A campaign can import local
|
||
`.txt` and `.md` files as Canon, Reference or Inspiration; retrieval is hybrid
|
||
(SQLite FTS5 plus local Ollama embeddings), reranked by relevance × class,
|
||
bounded by its own token budget, framed in the prompt as untrusted data with the
|
||
authority order stated in words, and fully traceable in the Insights panel. It is
|
||
a separate subsystem: AI-DnD's Story Cards were not promoted into it and are
|
||
untouched.
|
||
|
||
**What implementation forced into the active documents:**
|
||
|
||
- `TECHNICAL-DESIGN.md` §13.1 — **new.** The implemented pipeline, and four
|
||
decisions that each replaced an obvious wrong one: the class multiplies
|
||
relevance rather than adding to it; both retrieval scores are normalized per
|
||
query against the best of their own path; the relevance floor is therefore
|
||
relative rather than absolute; and lexical retrieval is a production path
|
||
rather than a fallback.
|
||
- `DATA-MODEL.md` §24A — **new.** The three tables and the FTS5 virtual table,
|
||
and the line between what the reader gave the campaign and what the machine
|
||
derived from it. Only a source's content and its classification are not
|
||
derivable.
|
||
- `DATA-MODEL.md` §25 — the retrieval record is **not** a table. It lives in the
|
||
turn's own context snapshot and carries the *rendered text*, because a table of
|
||
foreign keys would turn every historical turn's evidence into dangling
|
||
references the moment a source were deleted.
|
||
- `DATA-MODEL.md` §29 — what the bundle carries for imported knowledge, and why
|
||
passages, index rows and vectors are rebuilt rather than exported.
|
||
- `CONTEXT-AND-MEMORY.md` §29, §41-42, §46 — the knowledge budget as implemented
|
||
(a protected cap for always-included Canon, a share of the rest filled in
|
||
authority order), always-include as a Canon-only mechanism, and hidden Canon as
|
||
prompt discipline rather than as filtering.
|
||
- `IMPORTED-KNOWLEDGE-DESIGN.md` §76 — **new.** Where this document offered
|
||
options, which was chosen and why; and, named rather than left to be
|
||
discovered, the six things it contemplates that M7 does **not** implement —
|
||
entity linking, tags, manual priority, scene pinning, Canon-versus-Canon
|
||
conflict detection, and source versioning.
|
||
- `V1-ACCEPTANCE-TESTS.md` — results for G01-G10, C05, F05, F06, I05 and
|
||
H06-H09, marked as implementation-pass evidence rather than review findings.
|
||
F05 and F06 move from *PARTIAL / PASS for story memory* to complete. H09 is
|
||
recorded NOT APPLICABLE with a test that fails if an archive extractor is ever
|
||
added to this surface. **C05 is recorded as a pass on the assembled prompt
|
||
with the gap stated**: no real narrator generation was run against it.
|
||
- `BUILD-MILESTONES.md` M7 § Status — **new.** What was built beyond the scope
|
||
list, and the debt carried forward, deliberately.
|
||
|
||
**One runtime dependency was added**: `python-multipart`, Starlette's multipart
|
||
parser. It is what makes the upload surface possible, and the upload surface is
|
||
why no endpoint in the knowledge API accepts a filesystem path.
|
||
|
||
## v2.7 — M5 and M6 Closeout (2026-09-06)
|
||
|
||
Two milestones, and one lesson they share: an independent review found a real
|
||
defect in each after the implementation reported success, and in both cases the
|
||
defect was invisible to the tests the implementation had written for itself.
|
||
|
||
**M5 — Genre-Neutral Authoritative Narrative State.** Accepted 2026-09-04. Its
|
||
review returned *PASS WITH CORRECTIVE WORK REQUIRED*: editing a narrator turn
|
||
rewound the campaign's live state while the head stayed at the tip, breaking the
|
||
`transcript position == head == authoritative state` invariant. The corrective
|
||
pass rebuilt narrator editing on the §§14-15 fork semantics. Recorded here late:
|
||
M5's closeout did not add a package revision entry, and this one covers it.
|
||
|
||
**M6 — Branch-Safe Context, Summaries, and Long-Term Story Memory.** Accepted
|
||
2026-09-06. Sequence:
|
||
|
||
1. **Implementation.** Summaries moved onto lineage-anchored rows; memory
|
||
authority, provenance, an output reserve, and observable derived-work
|
||
failure were added. Reported as passing, including E03.
|
||
2. **Independent review — E03 still failed.** Summary *rows* were anchored, but
|
||
generation was seeded from `adventures.story_summary`, a campaign-global
|
||
column with no lineage. After a divergence the summariser was handed the
|
||
abandoned line's prose and asked to update it, so the new summary carried
|
||
abandoned content inside a correctly anchored row. The review also found F02
|
||
passing by a single retrieval slot, two test defects, and a misleading
|
||
derived-work status.
|
||
3. **Corrective pass.** Generation is seeded from `summaries.current`;
|
||
redundancy suppression was added before the retrieval cut; the test fixture
|
||
no longer makes real network calls; the browser suite gained a scenario that
|
||
regenerates a summary after divergence.
|
||
|
||
**What the planning package learned from M6, recorded in the active documents:**
|
||
|
||
- `CONTEXT-AND-MEMORY.md` §11 — lineage safety has two halves. Anchoring the
|
||
output row is not enough; the *input* to the summarizer must be scoped by the
|
||
same rule.
|
||
- `V1-ACCEPTANCE-TESTS.md` E03 — a valid test must regenerate a summary after
|
||
diverging. Checking only that the old row went ineligible passes while the
|
||
defect is live.
|
||
- `CONTEXT-AND-MEMORY.md` §20/§22 — what M6 implements (redundancy suppression
|
||
between memories) is now distinguished from what it does not (importance,
|
||
entity, recency and thread ranking; cross-layer duplication).
|
||
|
||
## v2.6 — M4 Closeout (2026-09-03)
|
||
|
||
M4 is **accepted**. Its review returned *PASS WITH CORRECTIVE WORK REQUIRED*; the
|
||
corrective work is done, and the browser condition that M3 and M4 both carried is
|
||
closed.
|
||
|
||
**The three review findings, fixed:**
|
||
|
||
- **B-1 — the Save Point list was an N+1.** It resolved each Save Point with its
|
||
own query and loaded whole `Action` rows, narration included, to answer "does a
|
||
row exist here". It is now one bulk two-column coordinate query plus one
|
||
lineage computation: **53 SELECTs for 25 Save Points became 5**, and the count
|
||
no longer grows with the list. Guarded by three tests, including one proving
|
||
the coordinate is matched as a *pair* — an `IN`-list version would report a
|
||
Save Point resolved because another branch has a live row at the same depth.
|
||
- **B-2 — deleting a branch silently deleted its Save Points.** Fixed as a
|
||
**behaviour** defect rather than a missing warning, because
|
||
`STORY-BRANCH-SEMANTICS.md` §19 says a named checkpoint remains until
|
||
explicitly deleted and §28 already required future cleanup to retain
|
||
checkpoint-referenced paths. **A branch a Save Point names can no longer be
|
||
deleted.** The request is refused with the offending Save Points named; the
|
||
user deletes them explicitly, which deletes no story, and the branch then
|
||
goes. Both delete controls disable and explain. Recorded as a new
|
||
**§19.1**.
|
||
- **B-3 — the D11/L03 automation never left one process.** A new module spawns
|
||
real server processes, kills the first, and reads the campaign back with the
|
||
second.
|
||
|
||
**Also fixed (review §S C-5):** creating a Save Point now takes the campaign's
|
||
turn lock, so "save where I am" cannot read a head a turn in flight is about to
|
||
move. Rename and Delete deliberately do not take it, and a test pins that
|
||
decision.
|
||
|
||
**Real-browser verification — the first in this project.** A Firefox 154.0.1
|
||
driven through geckodriver over the W3C WebDriver protocol exercised the rendered
|
||
DOM for **both** milestones: **44/44 checks passed**, no console errors. It
|
||
covered M3's Undo/Redo enable states, transcript movement, Retry and the take
|
||
pager, and divergence retiring Redo; and M4's whole Save Point lifecycle
|
||
including both confirmations and the new branch-delete warning. **The outstanding
|
||
M3 browser condition is therefore closed as well.** No dependency was added to
|
||
the repository: the WebDriver client for the run was written against stdlib HTTP.
|
||
|
||
**Also corrected, found while fixing B-2:** `models.py`, `TECHNICAL-DESIGN.md`
|
||
§8.8 and `DATA-MODEL.md` §8 all described the cascade as the durability rule.
|
||
They now describe the refusal, and record that `checkpoints.branch_id`'s cascade
|
||
survives as referential integrity that the application no longer reaches.
|
||
|
||
**Documents corrected by this closeout:**
|
||
|
||
- `V1-ACCEPTANCE-TESTS.md` records results for **D11-D14, I04, L03** and the
|
||
E-series, and states that the browser-level condition is satisfied. **No pass
|
||
condition was weakened** — and D11/L03 now note that the automation crosses a
|
||
genuine OS process boundary, which is the standard later milestones should
|
||
meet.
|
||
- `DATA-MODEL.md` §8 records the coordinate as implemented, with the retry
|
||
measurement that settles coordinate-versus-turn-id, and three decisions that
|
||
were previously implicit: names are not unique, several Save Points may name
|
||
one position, and the list is newest-created first.
|
||
- `STORY-BRANCH-SEMANTICS.md` gains **§19.1** — a checkpoint protects the
|
||
history it names. This is the only behavioural specification change in the
|
||
closeout, and it strengthens §19 rather than weakening anything.
|
||
- `BROWSER-UX-SPEC.md` §25 rules for the implemented vocabulary: **Moment N**,
|
||
not *Turn N*, because the branch panel and tree overlay already count in
|
||
moments. Vocabulary only; no behaviour changes.
|
||
- `BUILD-MILESTONES.md` marks **M4 COMPLETE**, records the fixes and the browser
|
||
result, and warns M5 that the instrumentation to move is now **55 tests**.
|
||
- `README.md` records M1-M4 accepted and M5 as next to brief.
|
||
- `PROJECT-SOURCES.md` and `project-sources.txt` point at the current report;
|
||
`project-sources.txt` still named the archived M3 report and was corrected.
|
||
|
||
**Report rotation** happened in the reporting pass that preceded this closeout:
|
||
`M3-IMPLEMENTATION-REPORT.md` moved to `archive/milestone-reports/` as a pure
|
||
rename, and `reports/` now holds M4's report, whose **§W** is this closeout's
|
||
evidence record.
|
||
|
||
**No new ADR.** ADR 012 already decides the architecture, and the corrective work
|
||
forced no new architectural decision. `SPECIFICATION.md`,
|
||
`STORY-BRANCH-SEMANTICS.md`, `SECURITY-THREAT-MODEL.md`, `CONTEXT-AND-MEMORY.md`,
|
||
`IMPORTED-KNOWLEDGE-DESIGN.md` and ADRs 003, 005 and 012 are unchanged.
|
||
|
||
**M5 readiness:** ready. Save Points store no state and no checkpoint code reads
|
||
any, so M5 can change what a snapshot contains without touching what a Save Point
|
||
is — provided it keeps state recoverable at a position without replay
|
||
(`TECHNICAL-DESIGN.md` §10.4).
|
||
|
||
## v2.5 — M4 Implementation (2026-09-03)
|
||
|
||
M4 added durable named Save Points. This revision records only what the
|
||
implementation established as fact; **no product requirement changed**, and the
|
||
milestone is **not** marked accepted — its review has not been written.
|
||
|
||
- `TECHNICAL-DESIGN.md` gains **§8.8** and **§9.2**: the Save Point as a name
|
||
plus a coordinate holding no story, restore as head movement with a bounds
|
||
check, the rule that the branch half of the head moves only when the
|
||
coordinate is off the path being read, restore never forking, and the bundle
|
||
carrying Save Points independently of the head.
|
||
- `DATA-MODEL.md` **§8** records the pointer as implemented — `(branch, depth)`
|
||
rather than a turn id, with the reason: one coordinate holds every attempt at
|
||
a turn and exactly one is live, so a coordinate follows a retry where a row id
|
||
would pin a superseded take. **§29** records the checkpoints in the export.
|
||
- `BUILD-MILESTONES.md` **M4** gains a status block: what shipped, the one
|
||
architectural decision the milestone had to make and why it needed no new ADR,
|
||
the test count, and the outstanding browser condition.
|
||
- `README.md` describes Save Points as a user-facing capability.
|
||
|
||
**No ADR was created.** ADR 012 already decides the architecture M4 needed —
|
||
restore reuses active-head movement — and a table is not a decision. The one
|
||
question ADR 012 does not answer, whether restore moves the branch half of the
|
||
head, is that same mechanism applied to a coordinate ADR 012 already defines;
|
||
`TECHNICAL-DESIGN.md` §8.8 records the answer rather than a new ADR asserting it.
|
||
|
||
`SPECIFICATION.md`, `SECURITY-THREAT-MODEL.md`, `STORY-BRANCH-SEMANTICS.md` and
|
||
`V1-ACCEPTANCE-TESTS.md` are unchanged. M4 altered no product requirement, added
|
||
no outbound path, and implemented the checkpoint semantics
|
||
`STORY-BRANCH-SEMANTICS.md` §18-25 already specified rather than amending them.
|
||
|
||
**The browser smoke test remains unperformed, now for both M3 and M4.** No
|
||
session has had a usable browser. See `BUILD-MILESTONES.md` M3 and M4.
|
||
|
||
## v2.4 — Documentation Consolidation (2026-09-03)
|
||
|
||
No product requirement, architecture decision or milestone status changed in
|
||
this revision. It reorganises the documentation so that a new coding agent can
|
||
tell authoritative material from evidence at a glance.
|
||
|
||
- `planning/archive/` is created and is **non-authoritative by declaration**
|
||
(`archive/README.md`). It holds `phase0/` — the research that chose AI-DnD —
|
||
`milestone-reports/` — the completed M1 and M2 reports — and `decisions/`,
|
||
which now holds ADR **008**, the Phase-0-before-build process gate that Phase 0
|
||
satisfied. ADR numbering continues from 012; 008 is not reused.
|
||
- `planning/reports/` now holds **only the current milestone's report**,
|
||
`M3-IMPLEMENTATION-REPORT.md`, because M4 planning has to consult it. It moves
|
||
to the archive when M4's report replaces it.
|
||
- The Phase 0B execution prompts and handoff/status/summary documents
|
||
(`CODEX-HANDOFF-NOTE.md`, `PHASE-0B-CODEX-BRIEF.md`,
|
||
`PHASE-0B-CODEX-HANDOFF.md`, `PLANNING-UPDATE-SUMMARY.md`) and the Phase 0A
|
||
discovery and triage reports were **deleted**: intermediate working documents
|
||
whose conclusions all reached the two recommendation reports, and which remain
|
||
in Git history.
|
||
- Upstream AI-DnD's inherited `plan/` build log and `docs/` project site
|
||
(guides, generated HTML, screenshots) were **deleted**. They documented a
|
||
hosted, scripted, multi-user product with accounts — every screenshot showed a
|
||
Scripts tab and a Sign up button — which M2 removed. Both trees remain in Git
|
||
history and in upstream.
|
||
- `README.md`, `DEVELOPMENT.md` and `PROVENANCE.md` are corrected where they
|
||
pointed at the removed trees or described removed capability as present.
|
||
`DEVELOPMENT.md`'s "things M1 did not touch" section had gone stale at M2 and
|
||
now says what is actually still inherited.
|
||
- `planning/README.md` is rewritten as **the documentation index**: current
|
||
milestone, the three-way active/ADR/archive split, the authority order,
|
||
reading order, where reports live, and what comes next. The milestone
|
||
correction tables are preserved unchanged.
|
||
- New: `planning/PROJECT-SOURCES.md` and `planning/project-sources.txt`, the
|
||
manifest of files to upload as ChatGPT Project Sources.
|
||
|
||
## v2.3 — Post-M3 Closeout (2026-09-03)
|
||
|
||
M3 replaced destructive Undo with a stored active head. Its review is
|
||
`archive/milestone-reports/M3-IMPLEMENTATION-REPORT.md`, which is also M3's primary evidence
|
||
record — no separate baseline report was produced — and whose §W records this
|
||
closeout.
|
||
|
||
In summary:
|
||
|
||
- the architecture is recorded as **ADR 012 — Active-Head Non-Destructive
|
||
History**: the head is stored rather than derived, every read of the story is
|
||
capped at it in one place, one mechanism moves it, state comes from the node
|
||
rather than from a replay, the first write below a moved-back head is the
|
||
divergence, and Redo is decided by the lineage rather than by a flag. ADR 005
|
||
is unchanged: it states the product requirement, and ADR 012 states the
|
||
architecture chosen to implement it,
|
||
- two history semantics are **ratified** in `STORY-BRANCH-SEMANTICS.md`: Undo
|
||
crosses fork points to the campaign opening (§5), and the system refuses to
|
||
switch which take is live while a later story is off screen (§10),
|
||
- a **new §14A** records the interim in-place-editing rule — refuse when story
|
||
descends from the turn and is not on screen — and states explicitly that
|
||
§14-15's full narrator-edit requirement stands and is completed in M5,
|
||
- `TECHNICAL-DESIGN.md` gains **§8.7** and **§9.1** recording the implemented
|
||
model and bundle behaviour as fact, and a constraint on §10.4: the snapshot
|
||
half of the hybrid state model is a requirement, because head movement must
|
||
not become proportional to campaign length,
|
||
- `DATA-MODEL.md` records the head as campaign-stored, the branch disposition as
|
||
implemented and deliberately advisory, and the export as carrying a chosen
|
||
position rather than a derived one,
|
||
- `BUILD-MILESTONES.md` marks **M3 complete**, states the one outstanding
|
||
condition (the browser smoke test), tells **M4** to reuse M3's head movement
|
||
rather than build a second restore path, and gives **M5** three constraints,
|
||
- `V1-ACCEPTANCE-TESTS.md` records D03's full pass, states **D10's milestone
|
||
ownership without weakening any pass condition**, adds I07's pre-M3 bundle
|
||
clause, and resolves the apparent L01/A05 conflict,
|
||
- `README.md` is corrected to describe the current local-only single-user
|
||
application rather than the upstream hosted one.
|
||
|
||
`SPECIFICATION.md` and `SECURITY-THREAT-MODEL.md` are unchanged: M3 altered no
|
||
product requirement and touched no path in the threat model.
|
||
|
||
## v2.2 — Post-M2 Closeout (2026-09-03)
|
||
|
||
M2 removed the hosted, cloud, account and scripting surface and added the
|
||
inference endpoint policy. Its review recommended six planning changes and
|
||
reported rather than applied them; all six are applied in this revision, listed
|
||
in `README.md` § *Post-M2 corrections applied*, with the evidence in
|
||
`archive/milestone-reports/M2-BASELINE-REPORT.md` and `archive/milestone-reports/M2-IMPLEMENTATION-REPORT.md`.
|
||
|
||
In summary:
|
||
|
||
- the **inference endpoint policy is recorded as implemented** — an address
|
||
allowlist of explicit local-network CIDRs, every resolved address checked,
|
||
enforced when settings are saved and again before every outbound request, with
|
||
TLS verification never traded against it (new **ADR 011**,
|
||
`SECURITY-THREAT-MODEL.md` §10A),
|
||
- its two **residual limits are stated rather than mitigated**: a hostile host
|
||
already on the trusted LAN, and the DNS-rebinding interval between the
|
||
policy's resolution and the client's connection,
|
||
- `TECHNICAL-DESIGN.md` §5.1 items 3 and 4 are **resolved**, and a new §5.2
|
||
records the M1/M2 production architecture as fact,
|
||
- a **wiring rule** is added (§18.1): removing a setting requires testing a real
|
||
consumer path, and adding one requires proving it reaches its component — M2
|
||
shipped two defects behind a 604-test green suite because the tests at that
|
||
boundary were mocks,
|
||
- `BUILD-MILESTONES.md` records **M2 complete**, warns M5 that eight rollback
|
||
tests use the world-state engine as instrumentation rather than as
|
||
architecture, and requires M6 to make background memory failure observable,
|
||
- the security acceptance contract is strengthened: **H10** now names the
|
||
wildcard-origin and `/api` 404 conditions, and new **H12** covers inference
|
||
endpoint enforcement including the database-edited-behind-the-API case.
|
||
|
||
`SPECIFICATION.md` is unchanged: M2 altered no product requirement. Nothing in
|
||
the architecture selected in v2 was reversed.
|
||
|
||
## v2.1 — Post-M1 Corrections (2026-09-02)
|
||
|
||
M1 implementation evidence contradicted or under-specified parts of v2. The
|
||
corrections are recorded in the documents themselves and listed in
|
||
`README.md` § *Post-M1 corrections applied*; the evidence behind them is in
|
||
`archive/milestone-reports/M1-BASELINE-REPORT.md` and `archive/milestone-reports/M1-IMPLEMENTATION-REPORT.md`.
|
||
|
||
In summary:
|
||
|
||
- a trusted-LAN Ollama may be **HTTPS with a privately issued certificate**;
|
||
clients verify against the operating system's CA store, with full certificate
|
||
and hostname verification and no bypass option (ADR 002,
|
||
`TECHNICAL-DESIGN.md` §5, A06),
|
||
- offline claims require a **fresh cache and no route out** to be evidence at
|
||
all, and vendored runtime artifacts should be integrity-verifiable
|
||
(ADR 004),
|
||
- A05's invariant is about **accepted** history; the user's submitted text is
|
||
deliberately retained on a failed turn,
|
||
- A06 requires a **real second machine and an HTTPS endpoint**; a plain-HTTP
|
||
LAN test is no longer sufficient evidence,
|
||
- the standard test environment records **CPU/GPU/RAM**, because cold model
|
||
load on a CPU-only host exceeded the inherited 120 s client timeout,
|
||
- `BUILD-MILESTONES.md` records M1 as complete and reframes M2's endpoint work
|
||
as **narrowing** an existing capability rather than inventing it,
|
||
- `SECURITY-THREAT-MODEL.md` §53 distinguishes **inbound** TLS (still deferred)
|
||
from **outbound** certificate verification (required, done in M1).
|
||
|
||
Nothing in the architecture selected in v2 was reversed.
|
||
|
||
## v2 — Post Phase 0B Revision (2026-09-01)
|
||
|
||
This v2 package supersedes the earlier planning package produced before the final Phase 0B review and the trusted-LAN Ollama deployment clarification.
|
||
|
||
Key v2 changes include:
|
||
|
||
- AI-DnD selected as the production base at the pinned Phase 0B commit.
|
||
- Non-destructive head-cursor Undo/Redo design selected.
|
||
- Explicit typed/absolute narrative-state events selected for production state handling.
|
||
- The authoritative narrative-state document — its shape, its authority/provenance fields, and the
|
||
event/document/snapshot split — recorded in ADR 013 after M5 implemented it.
|
||
- Imported knowledge separated from AI-DnD Story Cards.
|
||
- Trusted-LAN Ollama inference supported in v1 while the storyteller UI/API remains loopback-bound by default.
|
||
- Offline first-use dependencies and runtime remote assets identified as M1 hardening work.
|
||
- Production implementation divided into milestones M1-M11.
|
||
|
||
Historical Phase 0 prompts/reports are retained as evidence and should not be treated as current implementation instructions unless a current milestone prompt explicitly refers to them.
|